Fix shortlink mutations not reflecting in UI due to fire-and-forget revalidation#9
Draft
Copilot wants to merge 2 commits into
Draft
Fix shortlink mutations not reflecting in UI due to fire-and-forget revalidation#9Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Sarfraz-droid <73013838+Sarfraz-droid@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve implementation of callbacks for shortlink generation
Fix shortlink mutations not reflecting in UI due to fire-and-forget revalidation
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After creating, editing, or deleting a shortlink, the UI would intermittently not update because
revalidate()was called without being awaited — the fetch ran in the background while the component finished rendering with stale data.Changes
useFetch.ts—revalidatenow returnsPromise<void>instead ofvoidso callers can properlyawaititShortlinksContainer.tsx—createShortlinkawaitsrevalidate(), only revalidates on confirmed success, and shows toast feedback for both success and failure casesEditor/index.tsx—saveDataawaitsrevalidate()and auto-closes the modal after a successful saveMenu/Link/index.tsx—deleteLinkawaitsrevalidate()Button/index.tsx—clickHandlerusestry/finallysoisLoadingalways resets even when the callback throwsBefore / After
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
download.cypress.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node node index.js --exec install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.