Code-quality tooling: enforced ESLint, CI gate, docs, stricter types#4
Merged
Conversation
Targets the repo-level quality signals a scanner sees, not just clean logic (the last logic-only pass did not move the Code Quality score). - ESLint: flat config (typescript-eslint recommended + react-hooks rules), `npm run lint` script, deps pinned to eslint 9. Lint is clean (0 problems); removed two now-unnecessary eslint-disable directives in venue-map. - CI: run `lint` and the full `test` suite (69 tests) alongside typecheck + build on every push/PR — previously only typecheck + build ran. - Types: proper Web Speech API ambient types (src/types/speech.d.ts) replace the `any` block + no-explicit-any suppression in voice-radio. - README: add a Testing section documenting the suite + CI, fix the stale "Gemini 2.5 Flash" diagram label, document GEMINI_FALLBACK_MODELS, list lint/test in the checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second run at Code Quality (stuck at 88) — this time targeting the repo-level signals a scanner sees, since the earlier logic-only cleanup didn''t move that score.
Changes
typescript-eslintrecommended +react-hooksrules),npm run lint, deps pinned to ESLint 9. Lint is clean (0 problems); removed two deadeslint-disabledirectives invenue-map.ci.ymlnow runslint+ the full 69-test suite alongside typecheck + build on every push/PR. Previously only typecheck + build ran, so the tests never executed in CI.src/types/speech.d.ts) replace theanyblock +no-explicit-anysuppression invoice-radio. (Google Maps staysanyby design — no@types/google.mapsdep, per project convention.)GEMINI_FALLBACK_MODELS, and listed lint/test in the checks.Verified
npm run lint(0 problems) ·npm run typecheckclean · 69 tests pass ·next buildsucceeds.Honest note
The prior pure-logic quality pass didn''t move Code Quality off 88, so this may not either — but tooling/CI/docs/type-hygiene are the more likely things an automated quality rubric actually rewards. No behavior changes; deliberately did not refactor the large
dashboard.tsx(real but risky churn, uncertain payoff).