Demo verification: E2E bug fix, Lighthouse fixes, screenshots#7
Merged
Conversation
E2E (Playwright) walkthrough of every flow surfaced a real bug: closing the Ops Briefing / handover overlay while it was still generating would pop it back open when the Gemini call resolved (its setDoc fired unconditionally), and the lingering backdrop then blocked other controls. Guard the completion so it only surfaces if the operator hasn't already closed the overlay. Adds scripts/e2e-walkthrough.mjs (npm run e2e) — drives incident triage, briefing, copilot, emergency evacuation, staff, and tournament flows with real AI, asserting each and capturing screenshots. All 8 flows pass.
- CSP: allow fonts.googleapis.com / fonts.gstatic.com so Google Maps fonts load — removes the console-error CSP violations Lighthouse flagged (Best Practices). Live Lighthouse: Perf 94 / A11y 100 / BP 92 / SEO 100. - README: add a Screenshots section (ops room, emergency evacuation, staff console) captured from the E2E walkthrough. - Add theme.ts unit tests (densityState bands, phase labels, severity/ congestion maps). 85 -> 90 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification-focused pass to de-risk the live demo before submission.
End-to-end walkthrough (found a real bug)
scripts/e2e-walkthrough.mjs(npm run e2e) — Playwright drives every flow (incident triage, briefing, copilot, emergency evacuation, staff, tournament) with real AI, asserting each + capturing screenshots. All 8 flows pass.setDoc), and its backdrop then blocked other controls. Now the result only surfaces if the operator hasn't closed the overlay.Lighthouse (live URL)
fonts.googleapis.com), logging console errors. Allowed the Google font hosts instyle-src/font-src.Polish + tests
theme.tsunit tests. 85 → 90 tests.Verified: format/lint/typecheck clean · 90 tests · build succeeds · axe 0 violations · Lighthouse A11y 100.