Skip to content

feat: makes supportsClaim field mandatory in while posting a proof #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
semmet95 wants to merge 1 commit into from
Closed

feat: makes supportsClaim field mandatory in while posting a proof #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions acceptance/claim_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ var _ = Describe("Claim model tests", func() {
proofInput := api.ProofInput{
ClaimUriDigest: testClaim1Digest,
ReviewedBy: "ReviewerA",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: fmt.Sprintf("https://proof-claim1-support-%d", i),
}
proofBody, _ := json.Marshal(proofInput)
Expand All @@ -368,7 +368,7 @@ var _ = Describe("Claim model tests", func() {
proofInput := api.ProofInput{
ClaimUriDigest: testClaim1Digest,
ReviewedBy: "ReviewerB",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://proof-claim1-refute",
}
proofBody, _ := json.Marshal(proofInput)
Expand All @@ -382,7 +382,7 @@ var _ = Describe("Claim model tests", func() {
proofInput = api.ProofInput{
ClaimUriDigest: testClaim2Digest,
ReviewedBy: "ReviewerC",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://proof-claim2-support",
}
proofBody, _ = json.Marshal(proofInput)
Expand All @@ -396,7 +396,7 @@ var _ = Describe("Claim model tests", func() {
proofInput := api.ProofInput{
ClaimUriDigest: testClaim2Digest,
ReviewedBy: "ReviewerD",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: fmt.Sprintf("https://proof-claim2-refute-%d", i),
}
proofBody, _ := json.Marshal(proofInput)
Expand Down
12 changes: 6 additions & 6 deletions acceptance/proof_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ var _ = Describe("Proof model tests", func() {
proof1 := api.ProofInput{
ClaimUriDigest: sampleProof1.ClaimUriDigest,
ReviewedBy: sampleProof1.ReviewedBy,
SupportsClaim: &sampleProof1.SupportsClaim,
SupportsClaim: sampleProof1.SupportsClaim,
Uri: sampleProof1.Uri,
}
body1, err := json.Marshal(proof1)
Expand All @@ -89,7 +89,7 @@ var _ = Describe("Proof model tests", func() {
proof2 := api.ProofInput{
ClaimUriDigest: sampleProof2.ClaimUriDigest,
ReviewedBy: sampleProof2.ReviewedBy,
SupportsClaim: &sampleProof2.SupportsClaim,
SupportsClaim: sampleProof2.SupportsClaim,
Uri: sampleProof2.Uri,
}
body2, err := json.Marshal(proof2)
Expand Down Expand Up @@ -202,7 +202,7 @@ var _ = Describe("Proof model tests", func() {
proof := api.ProofInput{
ClaimUriDigest: "claim digest",
ReviewedBy: "ValidReviewer",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://example.com",
}
body, err := json.Marshal(proof)
Expand All @@ -227,7 +227,7 @@ var _ = Describe("Proof model tests", func() {
proof := api.ProofInput{
ClaimUriDigest: "validclaimdigest",
ReviewedBy: "Reviewer Name",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://example.com",
}
body, err := json.Marshal(proof)
Expand All @@ -252,7 +252,7 @@ var _ = Describe("Proof model tests", func() {
proof := api.ProofInput{
ClaimUriDigest: "",
ReviewedBy: "",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://example.com",
}
body, err := json.Marshal(proof)
Expand Down Expand Up @@ -301,7 +301,7 @@ var _ = Describe("Proof model tests", func() {
proof := api.ProofInput{
ClaimUriDigest: "validclaimdigest",
ReviewedBy: "ValidReviewer",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "http://not-https.com",
}
body, err := json.Marshal(proof)
Expand Down
4 changes: 2 additions & 2 deletions acceptance/source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ var _ = Describe("Source model tests", func() {
proofInput := api.ProofInput{
ClaimUriDigest: testClaim1Digest,
ReviewedBy: "ReviewerA",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://proof-claim1-true",
}
proofBody, _ := json.Marshal(proofInput)
Expand All @@ -275,7 +275,7 @@ var _ = Describe("Source model tests", func() {
proofInput = api.ProofInput{
ClaimUriDigest: testClaim2Digest,
ReviewedBy: "ReviewerB",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://proof-claim2-false",
}
proofBody, _ = json.Marshal(proofInput)
Expand Down
1 change: 1 addition & 0 deletions api/source-score.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@ components:
required:
- claimUriDigest
- reviewedBy
- supportsClaim
- uri
properties:
claimUriDigest:
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/server.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/domain/proof/proof_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func (pr *proofRepository) PostProof(ctx context.Context, proofInput *api.ProofI
proof := &api.Proof{
ClaimUriDigest: proofInput.ClaimUriDigest,
ReviewedBy: proofInput.ReviewedBy,
SupportsClaim: *proofInput.SupportsClaim,
SupportsClaim: proofInput.SupportsClaim,
Uri: proofInput.Uri,
UriDigest: uriDigest,
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/domain/proof/proof_repository_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var _ = Describe("Proof repository layer unit tests", Ordered, func() {
input := api.ProofInput{
ClaimUriDigest: sampleProof1.ClaimUriDigest,
ReviewedBy: "ReviewerA",
SupportsClaim: &sampleProof1.SupportsClaim,
SupportsClaim: sampleProof1.SupportsClaim,
Uri: sampleProof1.Uri,
}

Expand All @@ -29,7 +29,7 @@ var _ = Describe("Proof repository layer unit tests", Ordered, func() {
input = api.ProofInput{
ClaimUriDigest: sampleProof2.ClaimUriDigest,
ReviewedBy: "ReviewerB",
SupportsClaim: &sampleProof2.SupportsClaim,
SupportsClaim: sampleProof2.SupportsClaim,
Uri: sampleProof2.Uri,
}

Expand Down
12 changes: 6 additions & 6 deletions pkg/domain/proof/proof_service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var _ = Describe("Proof model service layer unit tests", Ordered, func() {
input := api.ProofInput{
ClaimUriDigest: sampleProof1.ClaimUriDigest,
ReviewedBy: sampleProof1.ReviewedBy,
SupportsClaim: &sampleProof1.SupportsClaim,
SupportsClaim: sampleProof1.SupportsClaim,
Uri: sampleProof1.Uri,
}

Expand All @@ -44,7 +44,7 @@ var _ = Describe("Proof model service layer unit tests", Ordered, func() {
input = api.ProofInput{
ClaimUriDigest: sampleProof2.ClaimUriDigest,
ReviewedBy: sampleProof2.ReviewedBy,
SupportsClaim: &sampleProof2.SupportsClaim,
SupportsClaim: sampleProof2.SupportsClaim,
Uri: sampleProof2.Uri,
}

Expand Down Expand Up @@ -155,7 +155,7 @@ var _ = Describe("Proof model service layer unit tests", Ordered, func() {
invalidInput := &api.ProofInput{
ClaimUriDigest: "claim digest",
ReviewedBy: "ValidReviewer",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://example.com",
}

Expand All @@ -176,7 +176,7 @@ var _ = Describe("Proof model service layer unit tests", Ordered, func() {
invalidInput := &api.ProofInput{
ClaimUriDigest: "validclaimdigest",
ReviewedBy: "Reviewer Name",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://example.com",
}

Expand All @@ -197,7 +197,7 @@ var _ = Describe("Proof model service layer unit tests", Ordered, func() {
invalidInput := &api.ProofInput{
ClaimUriDigest: "",
ReviewedBy: "",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "https://example.com",
}

Expand Down Expand Up @@ -238,7 +238,7 @@ var _ = Describe("Proof model service layer unit tests", Ordered, func() {
invalidInput := &api.ProofInput{
ClaimUriDigest: "validclaimdigest",
ReviewedBy: "ValidReviewer",
SupportsClaim: &supports,
SupportsClaim: supports,
Uri: "http://not-https.com",
}

Expand Down
Loading