Skip to content

chore: adds new claims from sources#14

Merged
semmet95 merged 2 commits into
mainfrom
chore/new-claims
May 3, 2026
Merged

chore: adds new claims from sources#14
semmet95 merged 2 commits into
mainfrom
chore/new-claims

Conversation

@semmet95
Copy link
Copy Markdown
Contributor

@semmet95 semmet95 commented May 2, 2026

No description provided.

@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Add custom validation rules and new news sources with claims

✨ Enhancement 🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Refactored validator to remove registry-based approach for compatibility
• Added custom validation rules via x-oapi-codegen-extra-tags support
• Implemented nonempty, nospace, and httpsurl validation rules
• Added 8 new news sources and 6 claims from multiple outlets
Diagram
flowchart LR
  A["Validator Refactor"] -->|Simplify| B["Direct Draft202012Validator"]
  A -->|Add| C["Custom Validation Rules"]
  C -->|Support| D["nonempty, nospace, httpsurl"]
  E["New Sources"] -->|Add| F["Al Jazeera, BBC, HT, SCMP"]
  F -->|Populate| G["6 New Claims"]
  B -->|Integrate| H["Enhanced Validation Pipeline"]
  C -->|Integrate| H
Loading

Grey Divider

File Changes

1. scripts/validate.py Bug fix, enhancement +78/-7

Refactor validator and add custom validation rules

scripts/validate.py


2. sources/al-jazeera.yaml ⚙️ Configuration changes +4/-0

Add Al Jazeera news source definition

sources/al-jazeera.yaml


3. sources/bbc.yaml ⚙️ Configuration changes +4/-0

Add BBC news source definition

sources/bbc.yaml


View more (9)
4. sources/ht.yaml ⚙️ Configuration changes +4/-0

Add Hindustan Times news source definition

sources/ht.yaml


5. sources/scmp.yaml ⚙️ Configuration changes +4/-0

Add South China Morning Post news source definition

sources/scmp.yaml


6. claims/al-jazeera/eu-sa-trade-deal.yaml Miscellaneous +4/-0

Add EU-Mercosur trade deal claim

claims/al-jazeera/eu-sa-trade-deal.yaml


7. claims/al-jazeera/us-tarrifs.yaml Miscellaneous +4/-0

Add US tariffs on EU claim

claims/al-jazeera/us-tarrifs.yaml


8. claims/bbc/fifa-italy-iran.yaml Miscellaneous +4/-0

Add FIFA World Cup replacement rumor claim

claims/bbc/fifa-italy-iran.yaml


9. claims/bbc/fifa-wc-caution.yaml Miscellaneous +4/-0

Add World Cup travel advisory claim

claims/bbc/fifa-wc-caution.yaml


10. claims/ht/china-zero-tarrif.yaml Miscellaneous +4/-0

Add China zero-tariff Africa policy claim

claims/ht/china-zero-tarrif.yaml


11. claims/ht/india-gdp.yaml Miscellaneous +4/-0

Add India GDP growth projection claim

claims/ht/india-gdp.yaml


12. claims/nyt/pentagon-google-ai.yaml Additional files +4/-0

...

claims/nyt/pentagon-google-ai.yaml


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented May 2, 2026

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0)

Grey Divider


Action required

1. Conflicting GDP figures 🐞 Bug ≡ Correctness
Description
claims/ht/india-gdp.yaml states a 7%–7.4% growth range in summary but claims 7.6% in title, so
the posted claim will be internally inconsistent for consumers.
Code

claims/ht/india-gdp.yaml[R2-3]

+summary: "Following a comprehensive revamp of the GDP base year to align with international standards, India's Chief Economic Advisor V Anantha Nageswaran has projected that the nation's real GDP growth for the 2026-27 financial year will range between 7% and 7.4%. This revised forecast is notably higher than the previous Economic Survey projection of 6.8% to 7.2%, reflecting increased domestic consumption and a modernized statistical framework."
+title: "India's FY26 growth seen at 7.6% in revamped GDP series"
Evidence
The same claim document contains two different growth figures, creating an objective contradiction
in the submitted payload; these documents are automatically POSTed after merge.

claims/ht/india-gdp.yaml[1-4]
AGENTS.md[5-8]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`claims/ht/india-gdp.yaml` contains conflicting GDP growth numbers: the summary says the forecast is **7%–7.4%**, while the title claims **7.6%**. This produces an internally inconsistent claim payload that will be POSTed to the API after merge.

### Issue Context
These repo documents are automatically posted after merge, so the inconsistency will propagate downstream.

### Fix Focus Areas
- claims/ht/india-gdp.yaml[1-4]

### Expected change
Update either `title` or `summary` so they reflect the same figure/range (aligned to the linked article).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Misspelled claim filenames 🐞 Bug ⚙ Maintainability
Description
Two new claim filenames contain typos (tarrifs, tarrif), which will make future discovery,
indexing, and maintenance harder.
Code

claims/al-jazeera/us-tarrifs.yaml[1]

+sourceUriDigest: "d77fe702137b27c8c8f04538dde3a2a48a1c9849d5e116e58aec80b229f4632f"
Evidence
The misspellings are in the added file paths, and can be corrected via renames without changing
document content.

claims/al-jazeera/us-tarrifs.yaml[1-4]
claims/ht/china-zero-tarrif.yaml[1-4]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The following new claim files have misspellings in their filenames:
- `claims/al-jazeera/us-tarrifs.yaml` (should be `tariffs`)
- `claims/ht/china-zero-tarrif.yaml` (should be `tariff`)

### Issue Context
While not schema-breaking, consistent naming improves maintainability and makes it easier to locate claims.

### Fix Focus Areas
- claims/al-jazeera/us-tarrifs.yaml[1-4]
- claims/ht/china-zero-tarrif.yaml[1-4]

### Expected change
Rename the files to:
- `claims/al-jazeera/us-tariffs.yaml`
- `claims/ht/china-zero-tariff.yaml`

(No content changes required.)

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Signed-off-by: Amit Singh <singhamitch@outlook.com>
@semmet95 semmet95 force-pushed the chore/new-claims branch from 0d134c7 to b9dd596 Compare May 2, 2026 17:28
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 12 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="claims/ht/india-gdp.yaml">

<violation number="1" location="claims/ht/india-gdp.yaml:2">
P2: The summary conflicts with the title on both fiscal year and GDP figure; keep one consistent claim statement in this record.</violation>
</file>

<file name="claims/nyt/pentagon-google-ai.yaml">

<violation number="1" location="claims/nyt/pentagon-google-ai.yaml:2">
P2: Remove the incorrect statement that the Department of Defense was renamed to the Department of War; it makes the claim record factually inaccurate.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread claims/ht/india-gdp.yaml
Comment thread claims/nyt/pentagon-google-ai.yaml Outdated
Comment thread claims/ht/india-gdp.yaml
Signed-off-by: Amit Singh <singhamitch@outlook.com>
@semmet95 semmet95 merged commit 0431b75 into main May 3, 2026
2 checks passed
@semmet95 semmet95 deleted the chore/new-claims branch May 3, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant