Skip to content

26 create additional metadata columns for control snap tables v0 and v1 #419

Open
Tobias-Pah wants to merge 17 commits intomainfrom
26-re-add-end_of_month-for-control_snap_v0
Open

26 create additional metadata columns for control snap tables v0 and v1 #419
Tobias-Pah wants to merge 17 commits intomainfrom
26-re-add-end_of_month-for-control_snap_v0

Conversation

@Tobias-Pah
Copy link
Contributor

@Tobias-Pah Tobias-Pah commented Feb 18, 2026

Description

following additional metadata columns in all Control Snap v0 and v1 models were added

  • beginning_of_week (this is arguable, some countries see sunday as first day of week. Pls add new global parameter like 'first_day_of_week' with default value '1' (?) , but make monday the default.)
  • end_of_week (same here)
  • beginning_of_month
  • end_of_month
  • beginning_of_quarter
  • end_of_quarter
  • beginning_of_year
  • end_of_year

in dbt project yml file there is additional variable datavault4dbt.first_day_of_week which defaults to 1 meaning monday, but can be set to 7 for sunday

Fixes #(issue)

Type of change

  • [ x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran the snapshot models and tests in automatic tests repo on databricks adapter for both datavault4dbt.first_day_of_week values 1 and 7

@Tobias-Pah Tobias-Pah added the testing To trigger the automated test workflow as internal User. label Feb 18, 2026
@remoteworkflow
Copy link

remoteworkflow bot commented Feb 18, 2026

dbt test combined result: ❌

Details

RESULTS for Synapse:
⚠️ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Postgres:
⚠️ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for BigQuery:
⚠️ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Redshift:
⚠️ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Snowflake:
⚠️ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Exasol:
⚠️ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Fabric:
⚠️ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Oracle:
⚠️ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Databricks:
⚠️ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for SQL Server:
⚠️ dbt-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/22136189241

@remoteworkflow remoteworkflow bot removed the testing To trigger the automated test workflow as internal User. label Feb 18, 2026
@remoteworkflow
Copy link

remoteworkflow bot commented Feb 18, 2026

dbt test combined result: ❌

Details

RESULTS for Synapse:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Postgres:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for BigQuery:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Redshift:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Snowflake:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Exasol:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Fabric:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Oracle:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Databricks:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for SQL Server:
⚠️ dbt-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/22135912682

@Tobias-Pah Tobias-Pah added the testing To trigger the automated test workflow as internal User. label Feb 24, 2026
@remoteworkflow
Copy link

remoteworkflow bot commented Feb 24, 2026

dbt test combined result: ❌

Details

RESULTS for Synapse:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Postgres:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for BigQuery:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Redshift:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Snowflake:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Exasol:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Fabric:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Oracle:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Databricks:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for SQL Server:
⚠️ dbt-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/22346601231

@remoteworkflow remoteworkflow bot removed the testing To trigger the automated test workflow as internal User. label Feb 24, 2026
@Tobias-Pah Tobias-Pah added the testing To trigger the automated test workflow as internal User. label Feb 24, 2026
@remoteworkflow
Copy link

remoteworkflow bot commented Feb 24, 2026

dbt test combined result: ❌

Details

RESULTS for Synapse:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Postgres:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for BigQuery:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Redshift:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Snowflake:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Exasol:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Fabric:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Oracle:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Databricks:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for SQL Server:
⚠️ dbt-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/22353436853

@remoteworkflow remoteworkflow bot removed the testing To trigger the automated test workflow as internal User. label Feb 24, 2026
@Tobias-Pah Tobias-Pah added the testing To trigger the automated test workflow as internal User. label Feb 25, 2026
@Tobias-Pah Tobias-Pah requested a review from tkiehn February 25, 2026 09:12
@remoteworkflow
Copy link

remoteworkflow bot commented Feb 25, 2026

dbt test combined result: ❌

Details

RESULTS for Synapse:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Postgres:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for BigQuery:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Redshift:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Snowflake:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Exasol:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Fabric:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Oracle:
❌ dbt-core-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for Databricks:
❌ dbt-core-tests
❌ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

RESULTS for SQL Server:
⚠️ dbt-tests
⚠️ dbt-fusion-tests
⚠️ dbt-macro-tests
⚠️ tech-tests

Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/22390094421

@remoteworkflow remoteworkflow bot removed the testing To trigger the automated test workflow as internal User. label Feb 25, 2026
tkiehn
tkiehn reviewed Mar 2, 2026
View reviewed changes
macros/tables/bigquery/control_snap_v0.sql
Comment on lines +19 to +23
{%- if first_day_of_week_var == 7 -%}
{%- set bigquery_day_of_week_arg = 'WEEK(SUNDAY)' -%}
{%- else -%}
{%- set bigquery_day_of_week_arg = 'WEEK(MONDAY)' -%}
{%- endif -%}
Copy link
Collaborator

@tkiehn tkiehn Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is not used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkiehn tkiehn tkiehn left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tobias-Pah @tkiehn @umattern