Skip to content

fix: add override_version for ansible-lint steps #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrienbourroux wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add override_version for ansible-lint steps #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f66305
fix: add override_version to ansible-lint steps
adrienbourroux Aug 7, 2026
22fed83
chore: add comment about override_version to ansible-lint steps
adrienbourroux Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ansible-linter/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ inputs:
description: "Path to a requirements.yml file used to install roles and collections before linting."
required: false
default: ""

files:
description: |
List of files to lint.
Expand All @@ -44,6 +43,8 @@ runs:
if: ${{ inputs.files == '' }}
uses: ansible/ansible-lint@262624cd0ab22a4221293216856c59671ce7aa5e # v26.6.0
with:
# Nested composites resolve github.action_ref to the parent; keep this SHA in sync with `uses`.
override_version: 262624cd0ab22a4221293216856c59671ce7aa5e

@EtienneM EtienneM Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I don't understand the purpose of this instruction. Ca you explain?

@adrienbourroux adrienbourroux Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it, in this nested composite action, github.action_ref incorrectly resolves to the parent Scalingo/actions commit. ansible-lint then uses that SHA to build a URL against its own repository, which results in a 404.

example in https://github.com/Scalingo/scalingo-ansible/actions/runs/31154931231/job/92792260688?pr=358
image

@adrienbourroux adrienbourroux Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EtienneM I added a comment to explain why override_version is needed. Is it clear enough now?

args: ${{ inputs.args }}
working_directory: ${{ inputs.working-directory }}
python_version: ${{ inputs.python-version }}
Expand All @@ -54,6 +55,8 @@ runs:
if: ${{ inputs.files != '' }}
uses: ansible/ansible-lint@262624cd0ab22a4221293216856c59671ce7aa5e # v26.6.0
with:
# Nested composites resolve github.action_ref to the parent; keep this SHA in sync with `uses`.
override_version: 262624cd0ab22a4221293216856c59671ce7aa5e
args: --version
working_directory: ${{ inputs.working-directory }}
python_version: ${{ inputs.python-version }}
Expand Down
Loading