chore: fix misc issues - #17
Merged
Merged
Conversation
EtienneM
previously approved these changes
Jun 19, 2026
yanjost
previously requested changes
Jun 19, 2026
yanjost
left a comment
yanjost
left a comment
There was a problem hiding this comment.
Thanks for tackling all these issues — the overall direction is great! I spotted two small problems that crept in during the refactoring, detailed inline below.
Following code review suggestion.
Following code review.
EtienneM
previously approved these changes
Jun 19, 2026
Now complies with --enable=all
SC-Jerome-S
self-requested a review
July 27, 2026 12:22
SC-Jerome-S
approved these changes
Jul 27, 2026
SC-Jerome-S
left a comment
SC-Jerome-S
left a comment
There was a problem hiding this comment.
Security review passed.
The PR introduces several security improvements - I noted an unvalidated branch parameter in cmnlib.sh but it's non critical since it's for client buildpack (controlling its own branch).
LGTM
matthieu526-scalingo
enabled auto-merge
July 27, 2026 13:13
matthieu526-scalingo
disabled auto-merge
July 27, 2026 13:13
matthieu526-scalingo
dismissed
yanjost’s stale review
July 27, 2026 13:14
Dismissing this review as Jerome approved it already and it is blocking the merge.
matthieu526-scalingo
approved these changes
Jul 27, 2026
matthieu526-scalingo
left a comment
matthieu526-scalingo
left a comment
There was a problem hiding this comment.
Approving to please GH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmn::str::joinis tested but not implemented #10cmn::bp::runfails to checkout a non-default branch #11cmn::jobs::waitis missing from thereadonly -fblock #12cmn::env::readsilently mishandles env files with=in their name #14cmn::bp::runexample has wrong argument order #15