-
Notifications
You must be signed in to change notification settings - Fork 81
feat(stacks): rework pages + new Jekyll tag #3812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Frzk
wants to merge
8
commits into
master
Choose a base branch
from
feat/stacks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3e51626
feat(stacks): update stacks overview
Frzk 7a2d90f
feat(stacks): introduce new Jekyll tag for stacks
Frzk cc9bb66
chore(stacks): rename stacks page
Frzk 11e9b1b
fix: update links to stacks page
Frzk 0a8231f
feat(stack tag): introduce new Jekyll stack tag
Frzk aff73ee
fix(stacks): update FIXMEs
Frzk cd5ead2
chore(stacks): fix erroneous links
Frzk f4c0693
chore(stacks): fix missing link
Frzk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,11 @@ | ||
| {% note %} | ||
| The [`scalingo-22`]({% post_url platform/internals/stacks/2000-01-01-scalingo-22-stack %}) stack is deprecated and will be discontinued on June 1, 2027. | ||
| Applications must be migrated to [`scalingo-24`]({% post_url platform/internals/stacks/2000-01-01-scalingo-24-stack %}) or [`scalingo-26`]({% post_url platform/internals/stacks/2000-01-01-scalingo-26-stack %}) before this date. | ||
| [{% scalingo 22 %}][scalingo-22] is now deprecated.\\ | ||
| It will be discontinued on June 1, 2027. Applications must be migrated to | ||
| another [stack], such as [{% scalingo 24 %}][scalingo-24] or | ||
| [{% scalingo 26 %}][scalingo-26] before this date. | ||
| {% endnote %} | ||
|
|
||
| [stack]: {% post_url platform/internals/stacks/2000-01-01-overview %} | ||
| [scalingo-22]: {% post_url platform/internals/stacks/2000-01-01-scalingo-22-stack %} | ||
| [scalingo-24]: {% post_url platform/internals/stacks/2000-01-01-scalingo-24-stack %} | ||
| [scalingo-26]: {% post_url platform/internals/stacks/2000-01-01-scalingo-26-stack %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| module Jekyll | ||
| class StackTag < Liquid::Tag | ||
| CLASSES = { | ||
| "26" => "supported", | ||
| "24" => "supported", | ||
| "22" => "deprecated", | ||
| "20" => "discontinued", | ||
| "18" => "discontinued", | ||
| "14" => "discontinued" | ||
| }.freeze | ||
|
|
||
| def initialize(tag_name, markup, tokens) | ||
| super | ||
| @stack = markup.strip | ||
| end | ||
|
|
||
| def render(context) | ||
| css_class = CLASSES.fetch(@stack, "unknown") | ||
|
|
||
| %(<span class="stack #{css_class}" title="Current status: #{css_class.capitalize}">scalingo-#{@stack}</span>) | ||
| end | ||
| end | ||
| end | ||
|
|
||
| Liquid::Template.register_tag("scalingo", Jekyll::StackTag) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -34,9 +34,9 @@ tailscale | |||||||||||||
| :repo:deb [trusted=yes] https://pkgs.tailscale.com/stable/ubuntu [dist] main | ||||||||||||||
| ``` | ||||||||||||||
|
|
||||||||||||||
| Replace `[dist]` with the codename of the [stack]({% post_url platform/internals/stacks/2000-01-01-stacks %}) you are using: | ||||||||||||||
| * `resolute` for `scalingo-26` | ||||||||||||||
| * `noble` for `scalingo-24` (default) | ||||||||||||||
| Replace `[dist]` with the codename of the [stack] you are using: | ||||||||||||||
| * `resolute` for `scalingo-26` (default) | ||||||||||||||
| * `noble` for `scalingo-24` | ||||||||||||||
|
Comment on lines
+38
to
+39
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: do we want to mention the "default" on this page? I'm pretty sure we will always forget to update it.. |
||||||||||||||
| * `jammy` for `scalingo-22` | ||||||||||||||
|
Comment on lines
+38
to
40
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion:
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| ## Step 3: Set TAILSCALE_AUTHKEY Environment Variable | ||||||||||||||
|
|
@@ -99,3 +99,6 @@ You can verify the connection by running a [one-off container]({% post_url platf | |||||||||||||
| {% note %} | ||||||||||||||
| The `ALL_PROXY` environment variable directs software that respects it (like `curl`) to use the local SOCKS5 proxy provided by Tailscale. | ||||||||||||||
| {% endnote %} | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| [stack]: {% post_url platform/internals/stacks/2000-01-01-overview %} | ||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! It displays nicely and makes it clear the status of the mentioned stack