Skip to content

chore(amqp): compile against librabbitmq-c-0.17.0 #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frzk merged 3 commits into from
Jul 3, 2026
Merged

chore(amqp): compile against librabbitmq-c-0.17.0 #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9de4f4a
chore(amqp): update to librabbitmq-c-0.17.0
Frzk Jul 3, 2026
c8ff07f
chore(amqp): update packaging script
Frzk Jul 3, 2026
01b3b32
chore(amqp): remove mentions to deprecated stacks
Frzk Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conf/versions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ PHP_MODULE_API_VERSIONS["8.5"]="20250925"
libmemcached_version="1.0.18"
# Mandatory for multibytes strings starting with PHP 7.4
libonig_version="${libonig_version:-6.9.10}"
librabbitmq_version="0.15.0"
librabbitmq_version="0.17.0"

memcached_version="3.4.0"
gmp_version="6.3.0"
Expand Down
172 changes: 73 additions & 99 deletions support/ext/amqp
View file
Open in desktop

@curzolapierre curzolapierre Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: so cleaner and easier to read!

Original file line number Diff line number Diff line change
Expand Up @@ -65,97 +65,80 @@ build_librabbitmq() {
download_archive "${archive_url}" \
| tar xvz --strip-components=1

if [ "${STACK}" = "scalingo-18" ]; then
cmake \
-DCMAKE_INSTALL_PREFIX="${librabbitmq_dir}" \
-DBUILD_TESTS=OFF \
-DBUILD_EXAMPLES=OFF \
-DBUILD_TOOLS=OFF \
-DBUILD_TOOLS_DOCS=OFF \
-DBUILD_API_DOCS=OFF \
-DRUN_SYSTEM_TESTS=OFF \
-DBUILD_SHARED_LIBS=ON \
-DBUILD_STATIC_LIBS=OFF \
-Wno-dev \
|| ( echo "Failed to build librabbitmq." \
&& exit 1 )
else
cmake \
-DCMAKE_INSTALL_PREFIX="${librabbitmq_dir}" \
-DBUILD_TESTING=OFF \
-DBUILD_EXAMPLES=OFF \
-DBUILD_TOOLS=OFF \
-DBUILD_TOOLS_DOCS=OFF \
-DBUILD_API_DOCS=OFF \
-DRUN_SYSTEM_TESTS=OFF \
-DBUILD_SHARED_LIBS=ON \
-DBUILD_STATIC_LIBS=OFF \
-Wno-dev \
|| ( echo "Failed to build librabbitmq." \
&& exit 1 )
fi

cmake \
--build . \
--config Release \
--target install \
|| ( echo "Failed to build librabbitmq." \
&& exit 1 )

popd

mkdir -p "${PREFIX}/lib"

if [ "${STACK}" = "scalingo-18" ]; then
# Move things that have been stored in `${prefix}/lib/x86_64-linux-gnu`
# to `${prefix}/lib` so that AMQP's `configure` finds them.
find "${librabbitmq_dir}/lib/x86_64-linux-gnu" \
-mindepth 1 \
-maxdepth 1 \
-exec mv --target-directory "${librabbitmq_dir}/lib/" -- {} \+

rmdir "${librabbitmq_dir}/lib/x86_64-linux-gnu"
fi

# Copy library to `$PREFIX/lib` so it's included in the future package
cp -ar "${librabbitmq_dir}" "${PREFIX}/lib/"
if ! cmake \
-DCMAKE_INSTALL_PREFIX="${librabbitmq_dir}" \
-DBUILD_TESTING=OFF \
-DBUILD_EXAMPLES=OFF \
-DBUILD_TOOLS=OFF \
-DBUILD_TOOLS_DOCS=OFF \
-DBUILD_API_DOCS=OFF \
-DRUN_SYSTEM_TESTS=OFF \
-DBUILD_SHARED_LIBS=ON \
-DBUILD_STATIC_LIBS=OFF \
-Wno-dev
then
echo "Failed to build librabbitmq."
exit 1
fi

if ! cmake \
--build . \
--config Release \
--target install
then
echo "Failed to build librabbitmq."
exit 1
fi

popd

mkdir --parents "${PREFIX}/lib"

# Copy library to `$PREFIX/lib` so it's included in the future package
cp --archive --recursive "${librabbitmq_dir}" "${PREFIX}/lib/"
}


build_amqp() {
local pkgname
local pkgver
local url
local librabbitmq_dir

pkgname="${1}"
pkgver="${2}"
url="${3}"
librabbitmq_dir="${4}"

printf -v archive_url "${url}" "${pkgver}"

mkdir -p "${pkgname}-${pkgver}"
pushd "${pkgname}-${pkgver}"

download_archive "${archive_url}" \
| tar xvz --strip-components=1

/app/vendor/php/bin/phpize \
|| ( echo "Failed to PHPize AMQP extension." \
&& exit 1 )

./configure \
--with-php-config="/app/vendor/php/bin/php-config" \
--with-librabbitmq-dir="${librabbitmq_dir}" \
|| ( echo "Failed to configure AMQP extension." \
&& exit 1 )

make \
|| ( echo "Failed to build AMQP extension." \
&& exit 1 )

popd
local pkgname
local pkgver
local url
local librabbitmq_dir

pkgname="${1}"
pkgver="${2}"
url="${3}"
librabbitmq_dir="${4}"

printf -v archive_url "${url}" "${pkgver}"

mkdir --parents "${pkgname}-${pkgver}"
pushd "${pkgname}-${pkgver}" > /dev/null

download_archive "${archive_url}" \
| tar --extract --gzip --strip-components=1

if ! /app/vendor/php/bin/phpize
then
echo "Failed to PHPize AMQP extension."
exit 1
fi

if ! ./configure \
--with-php-config="/app/vendor/php/bin/php-config" \
--with-librabbitmq-dir="${librabbitmq_dir}"
then
echo "Failed to configure AMQP extension."
exit 1
fi

if ! make
then
echo "Failed to build AMQP extension."
exit 1
fi

popd > /dev/null
}


Expand All @@ -182,12 +165,6 @@ pkgname="librabbitmq-c"
source_url="https://github.com/alanxz/rabbitmq-c/archive/refs/tags/v%s.tar.gz"

case "${STACK}" in
"scalingo-18")
version="0.11.0"
;;
"scalingo-20")
version="0.13.0"
;;
*)
version="${librabbitmq_version}"
;;
Expand All @@ -203,9 +180,6 @@ pkgname="amqp"
source_url="https://pecl.php.net/get/amqp-%s.tgz"

case "${STACK}" in
"scalingo-18")
version="1.11.0"
;;
*)
version="${amqp_version}"
;;
Expand All @@ -220,9 +194,9 @@ echo "extension=amqp.so" > "${PREFIX}/etc/conf.d/amqp.ini"
#
# | Stack | amqp | librabbitmq |
# | ----------- | ------ | ----------- |
# | scalingo-22 | 2.1.2 | 0.14.0 |
# | scalingo-20 | 2.1.2 | 0.13.0 |
# | scalingo-18 | 1.11.0 | 0.11.0 |
# | scalingo-26 | 2.2.0 | 0.17.0 |
# | scalingo-24 | 2.2.0 | 0.17.0 |
# | scalingo-22 | 2.2.0 | 0.17.0 |
#


Expand Down