Improve expression hiding #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Sonic, Pac-Man, Kazuya, Kirby, Dedede, etc.
Owner
|
Looks good. Thanks. If we want to implement this "properly" in the future, I would look into seeing what expressions are visible in the wait animations for each character and building the patterns based off of that. It's probably not worth spending a ton of time on a feature that's purely visual though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Sonic, Pac-Man, Kazuya, Kirby, Dedede, etc.
I was debating whether to include Sonic's ball form, Pac-Man's ball form and sprites, Samus and Dark Samus' ball form, Kazuya's devil form, etc. but I realized I would be going down a big rabbit hole for such a scuffed function so I just forewent implementing that.