feat(tags): add multi-file and subdirectory support for tags#12
Open
AndresCS20 wants to merge 1 commit into
Open
feat(tags): add multi-file and subdirectory support for tags#12AndresCS20 wants to merge 1 commit into
AndresCS20 wants to merge 1 commit into
Conversation
- Add recursive subdirectory support for loading tag YAML files (getAllYamlFiles) - Fix NullPointerException when rarity is not specified (defaults to common) - Refactor tag loading to support multiple YAML files in tags/ folder - Track which file each tag was loaded from for correct save/delete - Tags can now be organized in subfolders (tags/countries/, tags/flags/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ConfigManager.reloadTagConfigs()to recursively find all.ymlfilesgetAllYamlFiles()helper method for directory traversalTagManager.loadTags()to iterate over all tag config filestagSourceConfigmap to track which file each tag was loaded fromsection.getString("rarity", "common")instead ofsection.getString("rarity")Testing
Breaking Changes
None - fully backward compatible
Example Structure
tags/ ├── default.yml ├── countries/ │ ├── spain.yml │ └── argentina.yml └── flags/ ├── ocean.yml └── mountain.yml
Related Issue
Fixes NullPointerException: "Cannot invoke String.equalsIgnoreCase because getRarity() is null"