Detect breakpoint changes, and stop calling an unknown a no - #80
Merged
Conversation
방금 만든 코드에서 둘 나옴. setDebugState 가 중단점 목록을 길이로 비교했다. 하나 끄고 하나 켜면 길이가 같아서 사건이 안 나가고, 확장은 옛 목록 그대로 믿는다. 자리로 지문 만들어 비교하게 함. bpKey 로 빼서 테스트. find_references 가 워커 조회에 실패해도 "참조 없음(정의만 있음)" 이라고 답했다. 모델이 그걸 안 쓰는 코드로 읽고 지운다. asked 로 구분해서 못 물어본 경우엔 단정하지 말라고 답한다.
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects in code written earlier today, both from this session's recurring family.
Breakpoint changes compared by count
setDebugStatecompared the breakpoint list bylength. Turning one off and another on keeps the length identical, so no change event fired and extensions kept trusting the old list — marking the wrong lines.Now compared by a fingerprint built from the positions. Extracted to
src/engine/bpKey.tswith tests, including the equal-length case that motivated it."Could not ask" reported as "no references"
find_referencesanswered참조 없음(정의만 있음)even when the TS worker query failed or the worker was not up yet. A model reads that as dead code and deletes it.The answer now distinguishes the two: when the lookup did not actually happen it says so and tells the model not to conclude anything, pointing at
search_filesinstead.1108 unit tests passing (6 new).
npm run typecheckandnpm run buildclean.