downgrade.yml: default no_promote=Mooncake (skip its unresolvable floor-check)#106
Merged
ChrisRackauckas merged 1 commit intoJul 4, 2026
Conversation
…or-check) Adds a `no_promote` input (passed to julia-actions/julia-downgrade-compat) that keeps named weakdep extensions as weakdeps instead of floor-checking them. Defaults to `Mooncake`, whose dependency graph Resolver.jl cannot --min-resolve (StefanKarpinski/Resolver.jl#24) and which is registry-fragile, so its floor-check is skipped fleet-wide while every other weakdep extension is still floor-checked. Callers can override (e.g. add Reactant, or set empty to floor-check Mooncake). NOTE: inert until julia-actions/julia-downgrade-compat#52 (which adds the `no_promote` action input) merges and v2 is retagged; the currently-released v2 ignores the unknown `with:` key, so this is safe to land ahead of that. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
no_promoteinput to the reusabledowngrade.yml, passed through tojulia-actions/julia-downgrade-compat, defaulting toMooncake.no_promotekeeps the named weakdep extensions as weakdeps during merged downgrade resolution instead of promoting them into the joint floor-resolve (they install at latest, are never force-min-resolved). Mooncake is the fleet-wide culprit: its dependency graph cannot be--min-resolved byResolver.jl(StefanKarpinski/Resolver.jl#24 — Pkg resolves the identical graph fine), and the merged resolve is registry-fragile. Skipping just Mooncake's promotion greens the Downgrade lane fleet-wide while every other weakdep extension is still promoted and floor-tested together — the most conservative fix.Callers can override: add more backends (e.g.
Reactant), or setno_promote: ""to floor-check Mooncake in a repo where its graph happens to resolve.Ready — dependency satisfied
julia-actions/julia-downgrade-compat#52(which adds theno_promoteaction input) is merged and released as v2.6.0, and the movingv2tag now points to it (3cae9054), sojulia-downgrade-compat@v2used here already understandsno_promote. Merging this activates the fleet default immediately.Ready for review by @ChrisRackauckas.