Canonical CI: grouped-tests.yml + root test/test_groups.toml#133
Merged
ChrisRackauckas merged 1 commit intoJun 8, 2026
Merged
Conversation
Convert the root test workflow (Tests.yml) to the canonical thin caller SciML/.github/.github/workflows/grouped-tests.yml@v1, with the group x version matrix declared once in test/test_groups.toml at the repo root. The package already dispatches Core / NoPre via the GROUP env var in test/runtests.jl, so no runtests.jl change is needed. The TOML reproduces the previous matrix exactly: Core and NoPre each on [lts, 1, pre]. on: triggers and concurrency are preserved verbatim; filename and `name:` are unchanged so branch-protection status checks are preserved. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root test workflow
.github/workflows/Tests.ymlto the canonical thin callerSciML/.github/.github/workflows/grouped-tests.yml@v1, declaring the group × version matrix once in a ROOTtest/test_groups.toml.The package already dispatches
Core/NoPregroups via theGROUPenv var intest/runtests.jl(Category A), so noruntests.jlchange was made.NoPreruns the QA (Aqua) + JET checks, guarded byisempty(VERSION.prerelease)in runtests.jl.Changes
.github/workflows/Tests.yml: matrix test job replaced by the thin caller. Filename andname: "Tests"are unchanged so branch-protection status checks are preserved.on:triggers (pull_request / push / schedule,paths-ignore: docs/**) andconcurrency:are preserved verbatim.test/test_groups.toml(new, repo root): declares the matrix.No
with:inputs were needed: the old caller usedtests.yml@v1defaults throughout (GROUP env var,check-bounds: yes, coverage on,coverage-directories: src,ext), all of which are the defaults ofgrouped-tests.yml@v1.Matrix match — 6/6 exact
compute_affected_sublibraries.jl --root-matrix(fromSciML/.github@v1) emits exactly the previous workflow's cross product:Old workflow:
group ∈ {Core, NoPre} × version ∈ {1, lts, pre}= 6 cells. Emitted: the same 6 (group, version) pairs, allrunner: ubuntu-latest(Linux-only; noosfield added). Group names are passed verbatim toGROUP, preserving the existing runtests.jl dispatch.QA
Category A: existing QA (Aqua + JET) already wired via the
NoPregroup; static matrix-verify only, no local QA run. TOML and YAML both parse cleanly.Ignore until reviewed by @ChrisRackauckas.