QA: run_qa v1.6 form + ExplicitImports#122
Merged
ChrisRackauckas merged 2 commits intoJun 27, 2026
Merged
Conversation
Convert test/qa/qa.jl from the hand-rolled Aqua/JET body to the SciMLTesting 1.6 run_qa form and enable the ExplicitImports checks. - run_qa(DiffEqPhysics; explicit_imports = true, ...): Aqua + the six ExplicitImports checks now run via the shared harness (Aqua and ExplicitImports come from SciMLTesting's own deps). - ExplicitImports: 4 checks pass as-is. all_qualified_accesses_are_public and all_explicit_imports_are_public flag only OTHER packages' non-public names (ForwardDiff: GradientConfig/derivative/gradient/gradient!; RecipesBase: plot; Base: depwarn (Julia 1.10 only); SciMLBase: AbstractDynamicalODEProblem, AbstractSciMLSolution, FunctionArgumentsError, NullParameters, TooFewArgumentsError, TooManyArgumentsError, numargs). All are genuinely used (not stale), so they are ignored via ei_kwargs with the source pkg documented. - Aqua stale_deps: FIXED -- DiffEqCallbacks was declared in [deps] but never used anywhere in src or tests; removed from root [deps]/[compat]. Drops the prior stale_deps @test_broken. - Aqua deps_compat: the prior @test_broken is now stale (deps_compat passes); dropped. - JET: still reports genuine errors in src/plot.jl (RecipesBase.plot has no inferable method for OrbitPlot; DiffEqPhysics.plot/plot! undefined in plot_orbits). JET 0.11 (the `1` lane) surfaces these; JET 0.9 (the only version installable on the `lts` lane) does not. Kept as a static tracked @test_broken (issue SciML#118) rather than run_qa's version-auto-flagging jet_broken, which would Unexpected-Pass on lts and hard-FAIL on `1`. JET dropped from the qa env (no longer run there). - Removed the orphan test/explicit_imports.jl (its two checks, previously run in the Core group, are now part of the QA run_qa six) and the now-unused root ExplicitImports test dep. - qa Project.toml: SciMLTesting compat -> "1.6"; dropped JET and SafeTestsets (unused); kept Aqua (the ambiguities sub-check needs it a direct dep). Verified locally vs released SciMLTesting 1.6.0 (no dev-from-branch): release (Julia 1.12): Quality Assurance 17 pass / 0 fail-error; JET 1 broken. lts (Julia 1.10): Quality Assurance 17 pass / 0 fail-error; JET 1 broken. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SciMLTesting 1.7 runs the two public-API ExplicitImports checks (all_qualified_accesses_are_public / all_explicit_imports_are_public) only on Julia >= 1.11, and SciMLBase 3.24.0 made the previously-internal names public. Verified on Julia 1.12 against registered releases: - all_explicit_imports_are_public: all 7 SciMLBase names (AbstractDynamicalODEProblem, AbstractSciMLSolution, FunctionArgumentsError, NullParameters, TooFewArgumentsError, TooManyArgumentsError, numargs) are now public in SciMLBase 3.24.0 -> ignore-list dropped entirely. - all_qualified_accesses_are_public: dropped :depwarn (public in Base on >=1.11); kept the 4 ForwardDiff names (GradientConfig/derivative/gradient/gradient!) and :plot (RecipesBase), which remain non-public upstream. QA group green on 1.12 (17/17); public-API checks correctly skipped on lts. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Brings this repo's QA onto the SciMLTesting 1.6
run_qaform with ExplicitImports enabled (converts the hand-rolled Aqua/JETtest/qa/qa.jl).ExplicitImports findings (now enabled,
explicit_imports = true)Six checks run. Four pass as-is. The two public-API checks flag only other packages' non-public names, all genuinely used (not stale), so they are ignored via
ei_kwargswith the source package documented:all_qualified_accesses_are_publicGradientConfig,derivative,gradient,gradient!plotdepwarnall_explicit_imports_are_publicAbstractDynamicalODEProblem,AbstractSciMLSolution,FunctionArgumentsError,NullParameters,TooFewArgumentsError,TooManyArgumentsError,numargsno_implicit_imports,no_stale_explicit_imports,all_explicit_imports_via_owners,all_qualified_accesses_via_owners: pass, no ignores.Aqua
DiffEqCallbackswas in root[deps]/[compat]but unused anywhere insrc/tests; removed. Drops the priorstale_deps@test_broken.@test_brokenis now stale (the check passes); dropped.JET
JET still reports 3 genuine errors in
src/plot.jl(RecipesBase.plothas no inferable method forOrbitPlot;DiffEqPhysics.plot/plot!undefined inplot_orbits). This is JET-analysis-version dependent: JET 0.11 (the1lane) surfaces them; JET 0.9 (the only version installable on theltslane — JET 0.11 needs PrecompileTools floors incompatible with Julia 1.10) does not.Kept as a static tracked
@test_broken(issue #118) rather than run_qa's version-auto-flaggingjet_broken = true, which would Unexpected-Pass onltsand hard-FAIL on1. This preserves master's existing static JET placeholder exactly. JET dropped from the qa env (no longer run there).Other
test/explicit_imports.jl(its two checks, previously run in the Core group, are now part of the QA run_qa six) plus the now-unused rootExplicitImportstest dep.test/qa/Project.toml:SciMLTestingcompat ->"1.6"; droppedJETandSafeTestsets(unused); keptAqua(the ambiguities sub-check needs Aqua a direct dep).Verification (local, vs released SciMLTesting 1.6.0; no dev-from-branch)
🤖 Generated with Claude Code