Canonicalize test units with @safetestset#53
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Conversation
Wrap each independent test unit in `@safetestset` so it runs in its own module (isolation + world-age safety), matching the canonical OrdinaryDiffEq structure. - Core: the explicit-imports check and the recipe-exercise calls are now `@safetestset` units. The bare `plot(...)` recipe exercises moved to a self-contained test/recipes.jl loaded via `@safetestset include(...)`. - QA: the plain `@testset "Aqua"`/`@testset "JET"` units become `@safetestset`, each carrying its own imports. - Add SafeTestsets to the root [extras]/[targets].test/[compat] and to test/qa/Project.toml (the QA group activates its own project). Behavior-preserving: same tests run under the same GROUP dispatch, same assertions (including the `@test_broken` entries). Verified locally with `GROUP=Core` and `GROUP=QA` `Pkg.test()` on Julia 1.11. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
superseded by the v1.2 folder conversion on sciml-testing-rollout (#52) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Canonicalize the test suite so each independent test unit runs in its own module via
@safetestset(isolation between units + world-age safety), matching the canonical OrdinaryDiffEq structure.Core group
@safetestset "Explicit Imports" include("explicit_imports.jl").plot(...)recipe exercises (which had no assertions — they confirm the recipe runs without error) moved into a new self-containedtest/recipes.jl, loaded via@safetestset "Recipes" include("recipes.jl").QA group
@testset "Aqua"and@testset "JET"units intest/qa/qa.jlbecome@safetestset, each carrying its ownusingimports. TheAqua.test_all(...)call and the@test_brokenentries are preserved verbatim.Deps
SafeTestsetsadded to the root[extras]/[targets].test/[compat](SafeTestsets = "0.1, 1"), and totest/qa/Project.toml(the QA group activates its own project).Behavior-preserving
Same tests run under the same
GROUPdispatch, same assertions (including the@test_brokenentries). TheGROUPladder / runtests structure is otherwise unchanged.Verification (local, Julia 1.11)
GROUP=Core Pkg.test()->Explicit Imports2/2 pass;Recipesruns (0 assertions, as before). Passed.GROUP=QA Pkg.test()->Aqua6 pass / 2 broken;JET1 broken. Passed.Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code