QA: run_qa v1.6 form + ExplicitImports#54
Merged
ChrisRackauckas merged 1 commit intoJun 25, 2026
Merged
Conversation
Convert test/qa/qa.jl from the hand-rolled Aqua.test_all/JET @test_broken body onto the SciMLTesting 1.6.0 run_qa form, with ExplicitImports enabled. All six ExplicitImports checks pass with no ignore-lists. The three findings previously marked @test_broken (tracked in SciML#50) are now genuinely fixed rather than suppressed: - Aqua deps_compat: add [compat] bounds for the test-only Aqua/JET extras to the root Project.toml (the missing entries were the whole finding). - Aqua piracies: the @recipe-generated RecipesBase.apply_recipe method is owned by DimensionalPlotRecipes; clear it with aqua_kwargs = (; piracies = (; treat_as_own = [apply_recipe])). - JET: the is_key_supported(::Symbol) report lives in RecipesBase, not DimensionalPlotRecipes, so run_qa's default target_modules = (pkg,) scoping makes JET.test_package green; no jet_broken needed. Deps: - Bump SciMLTesting [compat] floor to "1.6" (root + test/qa). - Add RecipesBase to the qa sub-env (for the apply_recipe reference). - Drop ExplicitImports from the root [extras]/[targets].test (now transitive via SciMLTesting) and remove the redundant Core test/explicit_imports.jl; ExplicitImports now runs inside the QA group via run_qa. Verified locally against released SciMLTesting 1.6.0: QA group 18/18 pass, 0 broken/fail/error on Julia 1.10 (lts) and 1.11 ("1"); Core group still green. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Converts
test/qa/qa.jlfrom the hand-rolledAqua.test_all/JET@test_brokenbody onto the SciMLTesting 1.6.0run_qaform, with ExplicitImports enabled.ExplicitImports findings (
explicit_imports = true)All six checks pass with no ignore-lists and no
ei_broken:no_implicit_imports✅no_stale_explicit_imports✅all_explicit_imports_via_owners✅all_qualified_accesses_via_owners✅all_qualified_accesses_are_public✅all_explicit_imports_are_public✅The
srcis minimal and already fully-explicit (using RecipesBase: RecipesBase, @recipe,using LinearAlgebra: LinearAlgebra, norm).The three #50
@test_brokenfindings — all FIXED (none left broken)deps_compat— the rootProject.tomlwas missing[compat]entries for the test-onlyAqua/JETextras. Added them. (Fix, not suppression.)piracies— the@recipe-generatedRecipesBase.apply_recipemethod is owned byDimensionalPlotRecipes; cleared withaqua_kwargs = (; piracies = (; treat_as_own = [apply_recipe])).is_key_supported(::Symbol)— that report lives inRecipesBase, notDimensionalPlotRecipes.run_qa's defaultjet_kwargs = (; target_modules = (pkg,), mode = :typo)scopes it out, soJET.test_packageruns green (nojet_broken).This resolves all of #50.
Deps
SciMLTesting[compat]floor to"1.6"(root +test/qa).RecipesBaseto thetest/qasub-env (for theapply_recipereference).ExplicitImportsfrom the root[extras]/[targets].test(now transitive via SciMLTesting) and remove the now-redundant Coretest/explicit_imports.jl; ExplicitImports runs inside the QA group viarun_qa.Local verification (released SciMLTesting 1.6.0, resolved by Pkg — no dev-from-branch)
🤖 Generated with Claude Code