Fix minimum version bounds and NullParameters bug#29
Open
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:mainfrom
Open
Fix minimum version bounds and NullParameters bug#29ChrisRackauckas-Claude wants to merge 1 commit intoSciML:mainfrom
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:mainfrom
Conversation
- Update DiffEqBase minimum version from 6 to 6.165
- Catalyst 15 requires DiffEqBase >= 6.165, so the previous bound was too low
- Fix unqualified NullParameters reference in build_rhs.jl and build_rhs_ss.jl
- NullParameters is not exported from DiffEqBase, so it must be qualified as
DiffEqBase.NullParameters()
Note: Tests require MacroTools >= 0.5.17 (unreleased) or master for Julia 1.12
compatibility due to MethodList API changes in Julia 1.12.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
| first and then use that to create `ODEProblem`s. | ||
| """ | ||
| function DiffEqBase.ODEProblem(sys::FSPSystem, u0, tint, pmap = NullParameters()) | ||
| function DiffEqBase.ODEProblem(sys::FSPSystem, u0, tint, pmap = DiffEqBase.NullParameters()) |
Member
There was a problem hiding this comment.
Suggested change
| function DiffEqBase.ODEProblem(sys::FSPSystem, u0, tint, pmap = DiffEqBase.NullParameters()) | |
| function SciMLBase.ODEProblem(sys::FSPSystem, u0, tint, pmap = SciMLBase.NullParameters()) |
| Return a `SteadyStateProblem` for use in `DifferentialEquations. | ||
| """ | ||
| function DiffEqBase.SteadyStateProblem(sys::FSPSystem, u0, pmap = NullParameters()) | ||
| function DiffEqBase.SteadyStateProblem(sys::FSPSystem, u0, pmap = DiffEqBase.NullParameters()) |
Member
There was a problem hiding this comment.
Suggested change
| function DiffEqBase.SteadyStateProblem(sys::FSPSystem, u0, pmap = DiffEqBase.NullParameters()) | |
| function SciMLBase.SteadyStateProblem(sys::FSPSystem, u0, pmap = SciMLBase.NullParameters()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NullParametersreference inbuild_rhs.jlandbuild_rhs_ss.jl-NullParametersis not exported from DiffEqBase and must be qualified asDiffEqBase.NullParameters()Details
DiffEqBase Minimum Version
When attempting to resolve with the minimum DiffEqBase version (6.0), the package resolver fails because Catalyst 15 transitively requires DiffEqBase >= 6.165. This PR updates the bound to accurately reflect this constraint.
NullParameters Bug
The code was using an unqualified
NullParameters()in default function arguments:This causes an
UndefVarErrorat runtime becauseNullParametersis not exported fromDiffEqBase. The fix qualifies it asDiffEqBase.NullParameters().Test Plan
Note on Julia 1.12 Compatibility
Tests on Julia 1.12 currently require MacroTools from master due to a MethodList API change in Julia 1.12. The fix was merged to MacroTools in PR #217 but has not yet been released. Once MacroTools 0.5.17+ is released, CI should pass on Julia 1.12.
cc @ChrisRackauckas
🤖 Generated with Claude Code