Skip to content

Add ExplicitImports.jl checks to QA via SciMLTesting run_qa #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Jun 27, 2026
Merged

Add ExplicitImports.jl checks to QA via SciMLTesting run_qa #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4faaf12
Add ExplicitImports.jl checks to QA via SciMLTesting run_qa
ChrisRackauckas Jun 24, 2026
bce48cb
Convert QA to SciMLTesting 1.5 run_qa minimal form
ChrisRackauckas Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ authors = ["SciML"]
ComponentArrays = "0.15"
Random = "1.10"
SafeTestsets = "0.1"
SciMLTesting = "1"
SciMLTesting = "1.5"
Test = "1.10"
julia = "1.10"

Expand Down
5 changes: 4 additions & 1 deletion test/qa/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Aqua is otherwise a transitive dep of SciMLTesting, but it is kept here as a
# direct dep because Aqua's `Method ambiguity` check spawns a fresh subprocess
# that `using Aqua` against this env's load path, where only direct deps resolve.
[deps]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
FunctionProperties = "f62d2435-5019-4c03-9749-2d4c77af0cbc"
Expand All @@ -13,6 +16,6 @@ FunctionProperties = {path = "../.."}
Aqua = "0.8"
JET = "0.9,0.10,0.11"
SafeTestsets = "0.0.1, 0.1"
SciMLTesting = "1"
SciMLTesting = "1.5"
Test = "1"
julia = "1.10"
27 changes: 14 additions & 13 deletions test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
using FunctionProperties, Aqua, JET, Test
using SciMLTesting, FunctionProperties, JET, Test

@testset "Aqua" begin
# deps_compat disabled: missing [compat] for the Pkg test extra.
# Tracked in https://github.com/SciML/FunctionProperties.jl/issues/54
Aqua.test_all(FunctionProperties; deps_compat = false)
@test_broken false # Aqua deps_compat: missing compat for Pkg extra — tracked in https://github.com/SciML/FunctionProperties.jl/issues/54
end

@testset "JET" begin
# JET finds `Cassette.m is not defined` in overdub(::typeof(nameof), ...).
# Tracked in https://github.com/SciML/FunctionProperties.jl/issues/54
@test_broken false # JET: Cassette.m is not defined in overdub(::typeof(nameof), ...) — tracked in https://github.com/SciML/FunctionProperties.jl/issues/54
end
# `hasbranching` is a compiler-introspection utility: it `code_typed`s `f` and scans the
# resulting IR for `Core.GotoIfNot` nodes, and builds the dispatch signature with
# `Core.Typeof`. Both names are internal to `Core` with no public equivalent
# (`typeof` differs from `Core.Typeof` on type-valued arguments, and `Base.typesof`
# is itself non-public), so these two accesses are ignored in the public-API checks.
run_qa(
FunctionProperties;
explicit_imports = true,
ei_kwargs = (;
all_explicit_imports_are_public = (; ignore = (:GotoIfNot,)),
all_qualified_accesses_are_public = (; ignore = (:Typeof,)),
)
)
Loading