Bump OrdinaryDiffEqCore compat to 3.17 for JumpProcessesOrdinaryDiffEqCoreExt#582
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
…qCoreExt
The JumpProcessesOrdinaryDiffEqCoreExt imports StochasticDiffEqAlgorithm and
StochasticDiffEqRODEAlgorithm directly from OrdinaryDiffEqCore:
import OrdinaryDiffEqCore: OrdinaryDiffEqAlgorithm, DAEAlgorithm,
StochasticDiffEqAlgorithm, StochasticDiffEqRODEAlgorithm
These abstract types were first introduced into OrdinaryDiffEqCore in v3.17.0
(commit "Move SDE abstract algorithm types to OrdinaryDiffEqCore"). The previous
compat of "3, 4" permitted OrdinaryDiffEqCore as old as 3.0.0, which predates
the introduction of these types.
When a downstream package like MinimallyDisruptiveCurves.jl has a dependency
tree that resolves to OrdinaryDiffEqCore 3.1.0-3.16.x (e.g., because it pins
OrdinaryDiffEq 6.x in its Manifest), loading the JumpProcessesOrdinaryDiffEqCoreExt
fails with:
WARNING: Imported binding OrdinaryDiffEqCore.StochasticDiffEqAlgorithm was
undeclared at import time during import to JumpProcessesOrdinaryDiffEqCoreExt.
ERROR: UndefVarError: `StochasticDiffEqAlgorithm` not defined in
`JumpProcessesOrdinaryDiffEqCoreExt`
StochasticDiffEq's own CI does not expose this because StochasticDiffEq 7.x
requires OrdinaryDiffEqCore "4" and StochasticDiffEq 6.x defines these types
locally — so JumpProcesses always resolves to >= 3.17 in StochasticDiffEq's
test environment.
Fixes: SciML/MinimallyDisruptiveCurves.jl#50
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JumpProcessesOrdinaryDiffEqCoreExtimportsStochasticDiffEqAlgorithmandStochasticDiffEqRODEAlgorithmdirectly fromOrdinaryDiffEqCore, but these abstract types were only introduced in OrdinaryDiffEqCore v3.17.0. The previous compat bound"3, 4"permitted versions as old as 3.0.0, triggering a precompile failure when OrdinaryDiffEqCore resolves below 3.17."4"(which has the types), and StochasticDiffEq v6.x definesStochasticDiffEqAlgorithmlocally in its ownalgorithms.jl— so JumpProcesses always resolves to a new enough OrdinaryDiffEqCore when tested from StochasticDiffEq's suite.Change
OrdinaryDiffEqCore 3.17.0 is the first released version that defines
StochasticDiffEqAlgorithmandStochasticDiffEqRODEAlgorithm(introduced in the "Move SDE abstract algorithm types to OrdinaryDiffEqCore" commit, 2026-03-04; confirmed absent in 3.16.0 and present in 3.17.0).Test plan
🤖 Generated with Claude Code