Skip to content

Migrate ABDF2 eulercache to ESDIRKIMEXCache, drop legacy IE caches#3656

Merged
ChrisRackauckas merged 2 commits into
SciML:masterfrom
singhharsh1708:bdf-migrate-abdf2-to-esdirkimex
May 20, 2026
Merged

Migrate ABDF2 eulercache to ESDIRKIMEXCache, drop legacy IE caches#3656
ChrisRackauckas merged 2 commits into
SciML:masterfrom
singhharsh1708:bdf-migrate-abdf2-to-esdirkimex

Conversation

@singhharsh1708
Copy link
Copy Markdown
Contributor

@singhharsh1708 singhharsh1708 commented May 20, 2026

Summary

Migrates ABDF2’s first-step ImplicitEuler fallback to the unified ESDIRKIMEXCache path and removes the legacy ImplicitEulerCache / ImplicitEulerConstantCache from OrdinaryDiffEqSDIRK.

This was the last remaining non-generic SDIRK cache path.

Verification

  • ABDF2 matches master bit-exactly (naccept, u_end) for both IIP/OOP
  • SDIRK convergence: 82 pass / 2 broken
  • DAE suite: 8/8 pass
  • Existing FBDF/DFBDF allocation failures are unchanged and pre-existing

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Copy Markdown
Member

Needs a new minimum on the Project.toml.

@singhharsh1708 singhharsh1708 force-pushed the bdf-migrate-abdf2-to-esdirkimex branch from 78c915d to 414e1ea Compare May 20, 2026 13:54
@singhharsh1708
Copy link
Copy Markdown
Contributor Author

@ChrisRackauckas done..

@ChrisRackauckas ChrisRackauckas merged commit 62e3886 into SciML:master May 20, 2026
93 of 102 checks passed
@singhharsh1708 singhharsh1708 deleted the bdf-migrate-abdf2-to-esdirkimex branch May 20, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants