Fix ESDIRK659L2SA embedded coefficients so adaptive solves work (#3659)#3662
Merged
ChrisRackauckas merged 2 commits intoMay 21, 2026
Merged
Conversation
Contributor
Author
|
@ChrisRackauckas Do you have the paper's exact b̂ row to drop in instead? If so I'll use it verbatim as rationals |
Member
|
How does the paper state it? If it's long decimals, make them literal bigs like Verner |
c9372e4 to
fe10a22
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3659.
ESDIRK659L2SAadaptive solves were running toMaxItersbecause the embeddedbtildecoefficients were inconsistent (sum(btilde) ≠ 0), breaking the error estimator while leaving the main order-6 method itself correct.This PR replaces the embedded pair with a derived minimum-norm order-5 embedded solution satisfying the full order conditions for the fixed
(A,c)tableau. The primary method (A,b) is unchanged; only the adaptive error estimate is corrected.Verification
retcode=Successwith sane adaptive step countsμ=1000) adaptive solves behave normally againtableau_consistency_tests.jl:47/47pass (ESDIRK659L2SAmoved from@test_brokento@test)Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.