Skip to content

Move toward reusing OrdinaryDiffEqCore infrastructure #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oameye wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move toward reusing OrdinaryDiffEqCore infrastructure #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
667a664
Move toward reusing OrdinaryDiffEqCore infrastructure (refs #23)
oameye May 10, 2026
9243e06
move to IntegratorStats again
oameye May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ authors = ["Dennis Ogiermann <termi-official@users.noreply.github.com> and contr
CommonSolve = "38540f10-b2f7-11e9-35d8-d573e4eb0ff2"
DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
DiffEqBase = "2b5f629d-d688-5b77-993f-72d75c75574e"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
OrdinaryDiffEqCore = "bbf590c4-e513-4bbe-9b18-05decba2e5d8"
OrdinaryDiffEqLowOrderRK = "1344f307-1e59-4825-a18e-ace9aa3fa4c6"
PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
Expand All @@ -18,16 +19,17 @@ Unrolled = "9602ed7d-8fef-5bc8-8597-8f21381861e8"
[compat]
CommonSolve = "0.2.4"
DataStructures = "0.18.22, 0.19"
DiffEqBase = "6.165.1, 7"
DiffEqBase = "7"
ExplicitImports = "1"
ModelingToolkit = "10"
OrdinaryDiffEqCore = "1.19.0, 2, 3.1, 4"
OrdinaryDiffEqLowOrderRK = "1.7, 2"
OrdinaryDiffEqTsit5 = "1.1.0, 2"
ModelingToolkit = "11"
OrdinaryDiffEqCore = "4"
OrdinaryDiffEqLowOrderRK = "2"
OrdinaryDiffEqTsit5 = "2"
PrecompileTools = "1.0"
RecursiveArrayTools = "3.39.0, 4"
RecursiveArrayTools = "4"
SafeTestsets = "0.1.0"
SciMLBase = "2.77.0, 3.1"
SciMLBase = "3.1"
SciMLIterators = "1"
TimerOutputs = "0.5.28"
Unrolled = "0.1.5"
julia = "1.10"
Expand All @@ -37,7 +39,8 @@ ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78"
OrdinaryDiffEqTsit5 = "b1df2697-797e-41e3-8120-5422d3b24e4a"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLIterators = "efe4dcdd-3aed-4391-894d-a9dbd16a2f14"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["ExplicitImports", "ModelingToolkit", "OrdinaryDiffEqTsit5", "SafeTestsets", "Test"]
test = ["ExplicitImports", "ModelingToolkit", "OrdinaryDiffEqTsit5", "SafeTestsets", "SciMLIterators", "Test"]
16 changes: 7 additions & 9 deletions src/OrdinaryDiffEqOperatorSplitting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,15 @@ import SciMLBase: ReturnCode
import SciMLBase: DEIntegrator, NullParameters, isadaptive

import RecursiveArrayTools
import LinearAlgebra

import OrdinaryDiffEqCore: OrdinaryDiffEqCore, isdtchangeable,
stepsize_controller!, step_accept_controller!, step_reject_controller!

# In OrdinaryDiffEq v7 / DiffEqBase v7, passing verbose::Bool to inner ODE
# integrators is no longer supported. Convert Bool → DEVerbosity when available.
@static if isdefined(DiffEqBase, :DEVerbosity)
_inner_verbose(verbose::Bool) = verbose ? DiffEqBase.DEFAULT_VERBOSE : DiffEqBase.DEVerbosity(DiffEqBase.None())
else
_inner_verbose(verbose::Bool) = verbose
end
stepsize_controller!, step_accept_controller!, step_reject_controller!,
DEOptions

# DiffEqBase v7 no longer accepts verbose::Bool for inner ODE integrators; convert to DEVerbosity.
_inner_verbose(verbose::Bool) = verbose ? DiffEqBase.DEFAULT_VERBOSE : DiffEqBase.DEVerbosity(DiffEqBase.None())
_inner_verbose(verbose::DiffEqBase.DEVerbosity) = verbose

abstract type AbstractOperatorSplitFunction <: SciMLBase.AbstractODEFunction{true} end
abstract type AbstractOperatorSplittingAlgorithm end
Expand Down
Loading