Allow DomainSets 0.8#81
Merged
ChrisRackauckas merged 1 commit intoJun 4, 2026
Merged
Conversation
DomainSets 0.8 removed an old type piracy of `×` and unexported some internal symbols (now in FunctionMaps.jl). PDEBase only uses `DomainSets.infimum` and `DomainSets.supremum` (both fully qualified and still exported in 0.8), so no source changes are required — only the compat bound needs widening to admit 0.8. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
What
Widen the
DomainSetscompat bound from0.7to0.7, 0.8and bump the version to0.1.25.Why
This unblocks the DomainSets
0.7 -> 0.8dependabot bump in MethodOfLines.jl (SciML/MethodOfLines.jl#564). That PR currently fails to resolve because PDEBase (a MethodOfLines dependency) still pinsDomainSets = "0.7":DomainSets 0.8 breaking changes and why they don't affect PDEBase
DomainSets v0.8.0 (JuliaApproximation/DomainSets.jl#178):
DomainSets.×andLinearAlgebra.×are now distinct functions.PDEBase's only DomainSets usage is in
src/variable_map.jl:Both
infimumandsupremumare fully qualified and remain exported in DomainSets 0.8 (verified locally), and PDEBase uses no bare×and no unexported internals. So no source changes are required — only the compat bound.Local verification
DomainSets 0.8.0 was confirmed to provide every name PDEBase/MethodOfLines rely on:
A MethodOfLines test environment with this PDEBase branch + the matching ModelingToolkitBase compat bump developed in resolves DomainSets to 0.8.0 and runs the MethodOfLines Components and Diffusion test groups (see the MethodOfLines PR for full output). PDEBase precompiles cleanly against DomainSets 0.8.0.
🤖 Generated with Claude Code
Part of the DomainSets 0.8 set: SciML/MethodOfLines.jl#565 (consumer), SciML/ModelingToolkit.jl#4586 (ModelingToolkitBase, the other 0.7 pin).