Canonical CI: grouped-tests.yml + root test/test_groups.toml#85
Merged
ChrisRackauckas merged 1 commit intoJun 8, 2026
Merged
Conversation
Convert the root Tests.yml test workflow to the canonical thin caller (SciML/.github/.github/workflows/grouped-tests.yml@v1) and declare the group x version matrix once in test/test_groups.toml. - Core on [lts, 1, pre] - QA on [lts, 1] (kept off `pre` -- JET 0.11.x cannot resolve on 1.13 prereleases), reproducing the old workflow's `exclude: pre x QA`. runtests.jl already dispatches on GROUP (Core/QA), so no runtests.jl change is needed and the default group-env-name (GROUP) applies. The old caller used tests.yml@v1 with all defaults (check-bounds=yes, coverage=true, coverage-directories=src,ext, apt-packages=""), so the new thin caller needs no `with:` inputs. Root-matrix script reproduces the old matrix exactly: 5/5 cells. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root
Tests.ymltest workflow to the canonical thin caller usingSciML/.github/.github/workflows/grouped-tests.yml@v1, with the group × version matrix declared once in a new roottest/test_groups.toml.Changes
.github/workflows/Tests.yml— the matrix test job is replaced by the thin caller:name: "Tests", theon:triggers, andconcurrency:are preserved verbatim so branch-protection status checks are unaffected. No other workflow files were touched (Downgrade, Downstream, Documentation, FormatCheck, SpellCheck, TagBot, RunicSuggestions, DependabotAutoMerge, DocPreviewCleanup all left as-is).test/test_groups.toml(new):Why no
with:inputsruntests.jlalready dispatches on the standardGROUPenv var (Core/QA), so the defaultgroup-env-name(GROUP) applies. The old caller invokedtests.yml@v1with all defaults (check-bounds=yes,coverage=true,coverage-directories=src,ext,apt-packages=""), all of which matchgrouped-tests.yml's defaults — so the thin caller needs nowith:block.Matrix match: 5/5 exact
Old workflow matrix was
version: [1, lts, pre] × group: [Core, QA]withexclude: pre × QA→ 5 cells. Runningcompute_affected_sublibraries.jl <root> --root-matrixagainst the newtest/test_groups.tomlemits exactly:The QA-off-
preconstraint (JET 0.11.x cannot resolve on Julia 1.13 prereleases) is preserved by declaring QA'sversions = ["lts", "1"]rather than via a matrixexclude.Verification
test/test_groups.tomlparses (JuliaTOML);Tests.ymlparses (YAML).QA findings
None. This is a CI-plumbing change only;
runtests.jlalready had Core/QA GROUP dispatch (QA = JET static analysis), so no source or test changes were made.Ignore until reviewed by @ChrisRackauckas.