Merged
Conversation
Random.GLOBAL_RNG is not exported from Random and is not part of the public API. Replace with Random.default_rng() which is the supported public interface. Both return TaskLocalRNG on modern Julia versions, so this is a no-op behavior change but future-proofs against GLOBAL_RNG being deprecated. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Random.GLOBAL_RNGwithRandom.default_rng()in all 3 call sites (count_rand,ad_rand,pois_rand)Random.GLOBAL_RNGis not exported fromRandomand is not part of the public API.Random.default_rng()is the supported public interfaceTaskLocalRNGon Julia 1.10+, so this is a no-op behavior change but future-proofs againstGLOBAL_RNGbeing deprecatedTest plan
JULIA_DEPWARN=erroron Julia 1.12.4Upstream deps needing fixes
JULIA_DEPWARN=error🤖 Generated with Claude Code