Fix showcase doc breakages: SRIW1 import + 3-arg prob_func#337
Merged
ChrisRackauckas merged 1 commit intoMay 10, 2026
Merged
Conversation
DifferentialEquations.jl v8 only re-exports SciMLBase + OrdinaryDiffEq, so SRIW1 is no longer reachable via DE.SRIW1. Import StochasticDiffEq directly in the SPDE block (and add it to docs/Project.toml). The SciMLBase v3 ensemble interface calls prob_func with (prob, i, repeat). Update the two showcase prob_func definitions that still used the old 2-arg (prob, ctx) signature, which the existing batch_func no longer supplies. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
2 tasks
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/SciMLDocs
that referenced
this pull request
May 11, 2026
Upstream is now unblocked (AdvancedHMC 0.8.4 dropped the OrdinaryDiffEq umbrella dep, StochasticDiffEq 7.0.0 is registered with the DiffEqBase 7 ecosystem). Resolution now cleanly yields: OrdinaryDiffEq 7.0.0, OrdinaryDiffEqLowOrderRK 2.1.0, OrdinaryDiffEqStabilizedRK 2.1.0, StochasticDiffEq 7.0.0, SciMLBase 3.9.1, DiffEqBase 7.3.0, AdvancedHMC 0.8.4, DifferentialEquations 8.0.0. - Pin OrdinaryDiffEq = "7" and StochasticDiffEq = "7" so the resolver must land on the trimmed v7 stack the migration was designed for. - Revert the prob_func arity in the two showcase EnsembleProblem examples to the 2-arg `(prob, ctx)` form. SciMLBase v3 calls prob_func with `(prob, ctx::EnsembleContext)`; the earlier `(prob, i, repeat)` form (added in SciML#337 against SciMLBase v2.x) now errors as MethodError. The closures don't read i/repeat, so just taking `ctx` (and `ctx.sim_id` / `ctx.repeat` when needed) is forward-compatible. Verified locally on the v7 stack: smoke-test mirroring each migrated import block + first solve call passes, including the EnsembleProblem path. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
added a commit
that referenced
this pull request
May 12, 2026
DifferentialEquations.jl v8 only re-exports SciMLBase + OrdinaryDiffEq, and OrdinaryDiffEq v7 trims its umbrella exports to Tsit5/Vern6-9/ Rosenbrock23/Rodas5P/FBDF only. The remaining `import DifferentialEquations as DE` callsites that touched RK4/ROCK2/etc would silently break the moment the resolver picks OrdinaryDiffEq v7. Migrate every executable showcase to the per-sub-package idiom DiffEqDocs already uses: - import OrdinaryDiffEq as ODE for umbrella ODE algorithms - import OrdinaryDiffEqLowOrderRK for RK4 - import OrdinaryDiffEqStabilizedRK for ROCK2 - import StochasticDiffEq as SDE for SRIW1 (already done in #337) - import SciMLBase for EnsembleProblem/EnsembleThreads/terminate! (these aren't in OrdinaryDiffEq's `using SciMLBase: ...` list) docs/Project.toml pins DifferentialEquations to "8" and OrdinaryDiffEq to "6.111, 7" so the resolver is allowed to pick the trimmed v7 once upstream blockers (currently AdvancedHMC 0.8 capping at v6.111) lift. The two new sub-packages are added with compat "1, 2". Verified locally: a fresh env on the new Project.toml resolves DE 8.0.0 + OrdinaryDiffEq 6.111.0 + SciMLBase 2.155.1, and a smoke test mirroring each migrated import block + first solve call passes. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
The Documentation build on
mainis failing (and has been since the OrdinaryDiffEq v7 / DifferentialEquations v8 compat bumps in #334 / #335). Failing run that triggered this fix: https://github.com/SciML/SciMLDocs/actions/runs/25586532463/job/75116106072Summary
Three showcase pages were broken by recent compat bumps:
gpu_spde.md—DE.SRIW1()failed withUndefVarError: SRIW1 not defined in DifferentialEquations. DifferentialEquations.jl v8 only@reexportsSciMLBaseandOrdinaryDiffEq, so the StochasticDiffEq solvers are no longer available through theDEalias. Fix: importStochasticDiffEqdirectly in that block (added todocs/Project.tomlwith compat"6").massively_parallel_gpu.md—prob_func = (prob, ctx) -> ...failed withMethodError: no method matching (...)(::ODEProblem, ::Int64, ::Int64). The current SciMLBase ensemble interface callsprob_func(prob, i, repeat)(3 args). Fix: update the closure to the 3-arg signature. The cascading errors at lines 95-98 and 103-106 reuse the samemonteprob, so only one edit is needed.optimization_under_uncertainty.md— same root cause;prob_func(prob, ctx)becomesprob_func(prob, i, repeat). The downstreamUndefVarError: ensemblesoland the three subsequentMethodErrors onprob_funcall flow from this single definition.Test plan