Skip to content

🎨 Palette: Improve tab close button UX#212

Open
ScottMorris wants to merge 1 commit intomainfrom
palette-tab-close-icon-12344707818323890379
Open

🎨 Palette: Improve tab close button UX#212
ScottMorris wants to merge 1 commit intomainfrom
palette-tab-close-icon-12344707818323890379

Conversation

@ScottMorris
Copy link
Copy Markdown
Owner

This change improves the visual polish of the editor tabs by replacing the generic "×" character with a proper SVG icon (XMarkIcon) that matches the rest of the application's iconography. It also adds an aria-label to the close button, improving accessibility for screen reader users. The CSS was updated to remove padding that is no longer needed for the SVG icon, ensuring it remains perfectly centered within the circular button.


PR created automatically by Jules for task 12344707818323890379 started by @ScottMorris

Replaced the text-based "×" close button on tabs with the `XMarkIcon` SVG for better visual consistency and accessibility. Also removed padding from the button to better center the new icon.

- Replaced "×" text with `<XMarkIcon />` in `Tab.tsx`
- Added `aria-label="Close tab"` for accessibility
- Removed padding from `.tab-close` in `App.css`
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown

Desktop coverage summary

Metric Covered / Total Percent
Lines 270 / 1463 18.45%
Statements 292 / 1590 18.36%
Functions 63 / 421 14.96%
Branches 96 / 815 11.77%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant