security: require explicit P2P HMAC secret for gossip#2047
Open
createkr wants to merge 1 commit intoScottcjn:mainfrom
Open
security: require explicit P2P HMAC secret for gossip#2047createkr wants to merge 1 commit intoScottcjn:mainfrom
createkr wants to merge 1 commit intoScottcjn:mainfrom
Conversation
github-actions
bot
added
BCOS-L1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the insecure default fallback for
RC_P2P_SECRETin the P2P gossip module and makes the secret mandatory at startup.What changed
node/rustchain_p2p_gossip.pyRC_P2P_SECRETis unset, empty, or still a known insecure placeholder.env.exampleRC_P2P_SECRETis missingnode/test_p2p_secret_enforcement.pyWhy
The previous behavior allowed nodes to silently fall back to a public secret committed in source control. Any deployment that did not override
RC_P2P_SECRETcould accept forged HMAC-signed gossip messages.Validation
Ran:
All 4 tests passed.
Closes #2046
Payout Wallet
RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35