security: enforce TLS certificate validation by default#2049
Open
createkr wants to merge 1 commit intoScottcjn:mainfrom
Open
security: enforce TLS certificate validation by default#2049createkr wants to merge 1 commit intoScottcjn:mainfrom
createkr wants to merge 1 commit intoScottcjn:mainfrom
Conversation
|
Verified this security fix. The change properly removes insecure default TLS behavior and adds explicit opt-in for development mode with warnings. This is a critical security improvement - certificate validation should be enabled by default. Verification:
Labels look appropriate: security, documentation, BCOS-L1, size/M Looks good for merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change restores secure TLS behavior in the RustChain wallet and miner clients by keeping certificate validation enabled by default.
What changed
rustchain-wallet/src/client.rsrustchain-miner/src/transport.rsrustchain-miner/.env.exampleWhy
Disabling certificate validation allows HTTPS endpoints with invalid or attacker-controlled certificates to be accepted, which enables machine-in-the-middle interception and response tampering.
Validation
Closes #2048
Payout Wallet
RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35