[UTXO-BUG] reject empty-input non-minting transactions#2059
Open
createkr wants to merge 1 commit intoScottcjn:mainfrom
Open
[UTXO-BUG] reject empty-input non-minting transactions#2059createkr wants to merge 1 commit intoScottcjn:mainfrom
createkr wants to merge 1 commit intoScottcjn:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical UTXO validation bug where non-minting transactions with empty inputs could bypass conservation checks and create funds from nothing.
Root cause
In
node/utxo_db.py, the conservation check inapply_transaction()was gated byif inputs, so transactions withinputs=[]skipped the value-conservation path entirely. The same gap existed inmempool_add().What changed
transferand unknown transaction types inapply_transaction()mempool_add()transferrejectionmining_rewardpreservationtransferValidation
Updated tests in
node/test_utxo_db.pyto cover the exploit and the allowed minting path.Scope
node/utxo_db.pynode/test_utxo_db.pyPayout Wallet
RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35