security: verify BFT PRE-PREPARE messages before accept#2062
Merged
Scottcjn merged 1 commit intoScottcjn:mainfrom Apr 4, 2026
Merged
security: verify BFT PRE-PREPARE messages before accept#2062Scottcjn merged 1 commit intoScottcjn:mainfrom
Scottcjn merged 1 commit intoScottcjn:mainfrom
Conversation
Owner
|
Merged. 75 RTC. Real vulnerability — _handle_pre_prepare was skipping signature verification that _handle_prepare had. Nice catch. |
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change closes an authentication gap in the BFT consensus receive path by verifying
PRE-PREPAREmessage signatures and rejecting stale messages before proposal handling continues.What changed
_handle_pre_prepare()CONSENSUS_MESSAGE_TTLwindowWhy
PREPAREandCOMMITwere already authenticated on receipt, butPRE-PREPAREwas not. That left the proposal-carrying message type outside the normal verification path and allowed forged or stale PRE-PREPARE messages to reach downstream consensus logic.Scope
node/rustchain_bft_consensus.pyonlyCloses #2061
Payout Wallet
RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35