[UTXO-BUG] reject negative fees in transfer validation#2063
Merged
Scottcjn merged 1 commit intoScottcjn:mainfrom Apr 4, 2026
Merged
[UTXO-BUG] reject negative fees in transfer validation#2063Scottcjn merged 1 commit intoScottcjn:mainfrom
Scottcjn merged 1 commit intoScottcjn:mainfrom
Conversation
Owner
|
Merged. 200 RTC — Critical (Bounty #2819). Negative fee_nrtc bypasses conservation check — money printer exploit. Solid find. |
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a UTXO accounting bug where a negative
fee_nrtcvalue could weaken the conservation check inapply_transaction()and allow a normal transfer to create more value in outputs than existed in inputs.Root cause
apply_transaction()enforced value conservation usingoutput_total + fee <= input_total, but it did not validate thatfee_nrtcwas non-negative. A caller could set a negative fee to offset excess outputs and bypass the conservation check.What changed
fee_nrtcinapply_transaction()Why this matters
This affects normal transfer transactions with real inputs, not just minting-style paths. Without the non-negative fee guard, a transfer can inflate total supply by encoding the excess value as a negative fee.
Scope
node/utxo_db.pynode/test_utxo_db.pyPayout Wallet
RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35