Initial search results were missing distance from current location #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/nl/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/is/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/nb_NO/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/sv/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/pt/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/fr/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/fr_CA/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/ja/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/en_GB/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/de/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/pt_BR/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/fa/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/it/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/arz/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/da/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/pl/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/ru/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/uk/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/el/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/es/
Currently translated at 100.0% (1251 of 1251 strings) Translation: Soundscape Android/Android app Translate-URL: https://hosted.weblate.org/projects/soundscape-android/android-app/fi/
searchLocation is used to keep track of the userLocation used for searching. It's only initialized on the first composition, and so it was being left at null in previous code. We now also set it when search is triggered. That ensures that the search results know the location to measure the distance from and the distances are all displayed.
The focus around the search bar still doesn't feel great, but this is better because previously it was very hard to get to the search results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searchLocation is used to keep track of the userLocation used for searching. It's only initialized on the first composition, and so it was being left at null in previous code. We now also set it when search is triggered. That ensures that the search results know the location to measure the distance from and the distances are all displayed.