Skip to content

fix: derive HTTP URL from baseURL config instead of hardcoded localhost #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedevyashsaini merged 1 commit into from
May 29, 2026
Merged

fix: derive HTTP URL from baseURL config instead of hardcoded localhost #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/scrawn/src/core/scrawn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ export class Scrawn<
return this.apiKey;
}

/** Base URL for the HTTP API (derived from baseURL config) */
private httpUrl: string;

private sleep(ms: number): Promise<void> {
return new Promise((resolve) => setTimeout(resolve, ms));
}
Expand Down Expand Up @@ -223,6 +226,7 @@ export class Scrawn<

this.apiKey = config.apiKey;
this.retryCount = config.retryCount ?? 2;
this.httpUrl = this.buildHttpUrl(config.baseURL);
this.grpcClient = new GrpcClient(this.parseURLToTarget(config.baseURL), {
secure: config.secure ?? true,
credentials: config.credentials,
Expand All @@ -245,6 +249,16 @@ export class Scrawn<
: `${baseURL}:${ScrawnConfig.grpc.defaultPort}`;
}

private buildHttpUrl(baseURL: string): string {
if (baseURL.includes("://")) {
const url = new URL(baseURL);
return `http://${url.hostname}:8070`;
}

const host = baseURL.includes(":") ? baseURL.split(":")[0] : baseURL;
return `http://${host}:8070`;
}

/**
* Create a type-safe tag reference.
*
Expand Down Expand Up @@ -1289,7 +1303,7 @@ export class Scrawn<
async webhook(request: Request): Promise<WebhookEvent> {
if (!this.cachedPublicKey) {
const response = await fetch(
"http://localhost:8070/api/v1/internals/webhook-endpoint/public-key",
`${this.httpUrl}/api/v1/internals/webhook-endpoint/public-key`,
{ headers: { Authorization: `Bearer ${this.apiKey}` } }
);
if (!response.ok)
Expand Down
Loading