Update dev #83
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,29 @@ static_resources: | |
| - name: envoy.filters.network.http_connection_manager | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager | ||
| access_log: | ||
| - name: envoy.access_loggers.file | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog | ||
| path: /dev/stdout | ||
| log_format: | ||
| json_format: | ||
| timestamp: "%START_TIME%" | ||
| method: "%REQ(:METHOD)%" | ||
| path: "%REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%" | ||
| protocol: "%PROTOCOL%" | ||
| response_code: "%RESPONSE_CODE%" | ||
| grpc_status: "%GRPC_STATUS%" | ||
| content_type: "%REQ(content-type)%" | ||
| authority: "%REQ(:authority)%" | ||
| user_agent: "%REQ(user-agent)%" | ||
| x_forwarded_proto: "%REQ(x-forwarded-proto)%" | ||
| cf_ray: "%REQ(cf-ray)%" | ||
| cf_visitor: "%REQ(cf-visitor)%" | ||
| te: "%REQ(te)%" | ||
| upstream_host: "%UPSTREAM_HOST%" | ||
| upstream_cluster: "%UPSTREAM_CLUSTER%" | ||
| duration_ms: "%DURATION%" | ||
| stat_prefix: ingress_http | ||
| codec_type: AUTO | ||
| route_config: | ||
|
|
@@ -35,6 +58,9 @@ static_resources: | |
| cluster: http_backend | ||
| timeout: 60s | ||
| http_filters: | ||
| - name: envoy.filters.http.grpc_web | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.grpc_web.v3.GrpcWeb | ||
|
Comment on lines
+61
to
+63
There was a problem hiding this comment.
The |
||
| - name: envoy.filters.http.router | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typed_configbody under the access logger uses 4-space indentation while every othertyped_configblock in this file uses 2-space indentation. While valid YAML, it's inconsistent and makes the file harder to read.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!