Skip to content

feat(edge-apps-library): add optional latitude and longitude parameters to getTimeZone #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nicomiguelino wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(edge-apps-library): add optional latitude and longitude parameters to getTimeZone #671

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
085da57
feat(edge-apps-library): add optional latitude and longitude paramete…
nicomiguelino Feb 8, 2026
bdc9d12
test(edge-apps-library): add tests for getTimeZone optional parameter…
nicomiguelino Feb 8, 2026
18dc29c
test(edge-apps-library): revert changes to locale test cases
nicomiguelino Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions edge-apps/edge-apps-library/src/utils/locale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,14 @@ function isValidLocale(locale: string): boolean {
/**
* Resolve timezone configuration with fallback chain
* Fallback order: override setting (validated) → GPS-based detection → 'UTC'
*
* @param latitude - Optional latitude coordinate (overrides metadata coordinates)
* @param longitude - Optional longitude coordinate (overrides metadata coordinates)
*/
export async function getTimeZone(): Promise<string> {
export async function getTimeZone(
latitude?: number,
longitude?: number,
): Promise<string> {
// Priority 1: Use override setting if provided and valid
const overrideTimezone = getSettingWithDefault<string>(
'override_timezone',
Expand All @@ -83,8 +89,12 @@ export async function getTimeZone(): Promise<string> {
}

try {
const [latitude, longitude] = getMetadata().coordinates
return tzlookup(latitude, longitude)
// Use provided coordinates or fall back to metadata coordinates
const [lat, lng] =
latitude !== undefined && longitude !== undefined
? [latitude, longitude]
: getMetadata().coordinates
return tzlookup(lat, lng)
} catch (error) {
console.warn('Failed to get timezone from coordinates, using UTC:', error)
return 'UTC'
Expand Down