Update sellable charas to v3 and fix hardcoded values by perappu · Pull Request #274 · ScuffedNewt/lorekeeper

perappu · 2026-01-23T16:13:52Z

I had to do this for a site recently and figured it would be courteous to PR it back!

Updates extension to latest v3 (I was just going to PR the fixes alone, but composer wouldn't run until I updated to v3, lol...)
Fixed using hardcoded values for the Adoption Center, since under certain circumstances it can generate with an ID other than 1 (and we're removing hardcoded values from core too). In case you want to view just the adoption center changes and not the v3 stuff, it's here: 70d427a
- I got rid of some of the stuff surrounding potential multiple adoption centers because it's both unused and was causing issues. For example, you can't call facades or config to dynamically get an ID in admin_sidebar.php so I just changed admin/data/adoptions/edit/1 to just admin/data/adoptions. I did preserve most of the backend logic in case that feature is ever fully implemented.
Fixed hardcoding the admin user ID for the same reason.
Fixes validation that didn't trigger for the cost/currency id when creating stock.
Overall just did some clean-up to bring the extension in line with V3 standards

Thanks for your time!

- add webp to allowed upload formats - use imagick for large (2k px+ images) - add configurable/optional size cap

* fix issue lk-arpg#728 * fix lk-arpg#96 * fix lk-arpg#113 * Update birthday selector on register * fix lk-arpg#225 * fix lk-arpg#226 * fix lk-arpg#346 * fix lk-arpg#558 * fix lk-arpg#460 * fix lk-arpg#459 * fix lk-arpg#91 * Apply fixes from lk-arpg#91 to prompt submissions * refactor: fix blade formatting * remove character item retention due to return input wackiness * refactor: fix PHP styling * array_unique on slugs for gallery * add missing set active on user sidebars * add comment history and bugfix for likes * refactor: fix blade formatting * tweak function docs and sales comments checks * refactor: fix blade formatting * Capitalise 'carbon' in UserService * refactor: fix PHP styling --------- Co-authored-by: Ne-wt <Ne-wt@users.noreply.github.com>

Bumps [vue](https://github.com/vuejs/core) from 3.3.9 to 3.3.11. - [Release notes](https://github.com/vuejs/core/releases) - [Changelog](https://github.com/vuejs/core/blob/main/CHANGELOG.md) - [Commits](vuejs/core@v3.3.9...v3.3.11) --- updated-dependencies: - dependency-name: vue dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [mockery/mockery](https://github.com/mockery/mockery) from 1.6.6 to 1.6.7. - [Release notes](https://github.com/mockery/mockery/releases) - [Changelog](https://github.com/mockery/mockery/blob/1.6.x/CHANGELOG.md) - [Commits](mockery/mockery@1.6.6...1.6.7) --- updated-dependencies: - dependency-name: mockery/mockery dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [intervention/image](https://github.com/Intervention/image) from 2.7.2 to 3.0.1. - [Commits](Intervention/image@2.7.2...3.0.1) --- updated-dependencies: - dependency-name: intervention/image dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…evelop/vue-3.3.11 chore(deps-dev): bump vue from 3.3.9 to 3.3.11

…op/mockery/mockery-1.6.7 chore(deps-dev): bump mockery/mockery from 1.6.6 to 1.6.7

…op/intervention/image-3.0.1 chore(deps): bump intervention/image from 2.7.2 to 3.0.1

Conflicts: resources/views/galleries/create_edit_submission.blade.php

…processing feature/improved image processing

* - Switch from laravel/ui to laravel/fortify for authentication - Implement two-factor authentication * Fix user model reference * Adjust email verification resend url * Partially override fortify routes to disable the default two-factor enable/disable routes * feat(auth): reimplement invitation consumption * fix: remove laravel/ui routes * refactor: fix PHP styling * feat(users): update fortify implementation - make recaptcha toggleable in config - implement laravel honeypot on fortify routes - fix resend verification email route * refactor: fix blade formatting * fix(users): fix login form display - remove redundant controller functions * fix(users): put back confirm 2FA function * refactor: fix PHP styling * chore(deps-dev): update JS dependencies * refactor: fix blade formatting * fix(users): add notice to 2FA settings re alias login * refactor: fix blade formatting * refactor(users): move register validator to UserService --------- Co-authored-by: itinerare <itinerare@users.noreply.github.com>

Conflicts: resources/views/user/_sidebar.blade.php

Misc bugfixes/tweaks

- resolves error with old orderByRaw method

…lk-arpg#745)

feature/laravel 10

fix(characters): update design update feature ordering

Conflicts: app/Models/Character/CharacterDesignUpdate.php

…k-arpg#1278)

* fix(ranks): parsed rank description upon initial setup * refactor: fix PHP styling --------- Co-authored-by: liwoyadan <liwoyadan@users.noreply.github.com>

…bmission character notif (lk-arpg#1281)

…k-arpg#1314)

…ting (lk-arpg#1315)

* fix: add captcha block to register_with_driver.blade.php * refactor: fix blade formatting --------- Co-authored-by: perappu <perappu@users.noreply.github.com>

…g#1319)

…lk-arpg#1318) - add some minor eager loading

…pg#1323)

* fix(user profiles): Rank info help does not appear if description empty * I did not think this through * ..Not sure if big improvement? * And we flip back

…1348)

…1385)

* fix(character): Minor button renaming * Change 'Edit Notes' to 'Edit Description' * Change 'Edit Features' to 'Edit Traits' link text

…as' into extension-pr/sellable-charas

…rors

itinerare and others added 30 commits December 7, 2023 13:23

feat(galleries): add additional image processing options

a736629

- add webp to allowed upload formats - use imagick for large (2k px+ images) - add configurable/optional size cap

refactor: fix PHP styling

57d2511

Merge pull request lk-arpg#738 from corowne/dependabot/npm_and_yarn/d…

3c63210

…evelop/vue-3.3.11 chore(deps-dev): bump vue from 3.3.9 to 3.3.11

Merge pull request lk-arpg#739 from corowne/dependabot/composer/devel…

6b938f6

…op/mockery/mockery-1.6.7 chore(deps-dev): bump mockery/mockery from 1.6.6 to 1.6.7

Merge pull request lk-arpg#740 from corowne/dependabot/composer/devel…

cb69759

…op/intervention/image-3.0.1 chore(deps): bump intervention/image from 2.7.2 to 3.0.1

refactor: fix blade formatting

55bf708

Merge branch 'develop'

9aa31db

Conflicts: resources/views/galleries/create_edit_submission.blade.php

Merge pull request lk-arpg#737 from itinerare/feature/improved-image-…

f82a7f2

…processing feature/improved image processing

Merge branch 'develop'

911862e

Conflicts: resources/views/user/_sidebar.blade.php

feat(users): add message to honeypot error response

8b22be4

Merge pull request lk-arpg#744 from itinerare/main

a3d145a

Misc bugfixes/tweaks

feat!: update to Laravel 10

dbf910e

chore(deps): set minimum stability to stable

be15281

refactor: move model dates to casts

6961a82

fix(characters): simplify character image feature ordering

11ead09

- resolves error with old orderByRaw method

refactor: fix PHP styling

e4976c0

fix(characters): allow masterlist staff to see design update comments (…

0c14960

…lk-arpg#745)

Merge pull request lk-arpg#746 from itinerare/feature/laravel-10

ae89210

feature/laravel 10

refactor: fully qualify use statements for better static analysis

37ac912

fix(characters): update design update feature ordering

e008454

Merge pull request lk-arpg#747 from corowne/itinerare-patch-1

418e120

fix(characters): update design update feature ordering

refactor: update model relations to class references

3e0806c

refactor: use config() helper instead of Config::get()

ee5e5f2

refactor: fix PHP styling

d18e177

Merge branch 'develop'

fad92c5

Conflicts: app/Models/Character/CharacterDesignUpdate.php

Draconizations and others added 30 commits May 20, 2025 12:13

fix(shops): validate name uniqueness against shops table on creation (l…

d2e54bd

…k-arpg#1278)

fix(ranks): set parsed description on initial setup (lk-arpg#1280)

5268dec

* fix(ranks): parsed rank description upon initial setup * refactor: fix PHP styling --------- Co-authored-by: liwoyadan <liwoyadan@users.noreply.github.com>

fix(galleries): fix check for character owner when sending gallery su…

24eb86c

…bmission character notif (lk-arpg#1281)

fix: use own filemtime for custom.css (lk-arpg#1287)

09e8dce

fix: expand site settings admin panel description column (lk-arpg#1290)

30ef9a9

fix: add visual trait indexes trait modals to credits (lk-arpg#1299)

7998f4b

chore: fix minor config file typo (lk-arpg#1306)

ee086f0

docs: update contributing (lk-arpg#1303)

96557ba

fix(users): add fallback display text text if no primary alias set (l…

faee184

…k-arpg#1314)

fix(characters): add checks for species, rarity to image features edi…

54b8671

…ting (lk-arpg#1315)

refactor: fix PHP styling

966fca6

fix(users): add recaptcha to alias register view (lk-arpg#1317)

20ed6cf

* fix: add captcha block to register_with_driver.blade.php * refactor: fix blade formatting --------- Co-authored-by: perappu <perappu@users.noreply.github.com>

fix(submissions): add eager loading for submission characters (lk-arp…

e3c5659

…g#1319)

fix(characters): refactor stack name retrieval in character inventory (…

2e27044

…lk-arpg#1318) - add some minor eager loading

fix(ranks): clear parsed_description if description is not set (lk-ar…

d1bafd1

…pg#1323)

fix(users): hide rank info display on profile if unset (lk-arpg#1322)

52d73c2

* fix(user profiles): Rank info help does not appear if description empty * I did not think this through * ..Not sure if big improvement? * And we flip back

fix: remove extra whitespace from view titles, meta tags (lk-arpg#1324)

18a7b19

fix(users): refine forgot password message check (lk-arpg#1334)

8cab684

fix(prompts): fix typo in sidebar (lk-arpg#1339)

1e4ad24

fix(items): include stack_name in character item pivot (lk-arpg#1342)

07f1899

fix(characters): add decimal validation rule for sale value (lk-arpg#…

2d4f729

…1348)

chore(workflows): use self-contained workflows (lk-arpg#1356)

8fba701

chore(workflows): pull before committing lint changes (lk-arpg#1369)

cfd3634

fix(users): get lowest existing rank when creating new user (lk-arpg#…

713f962

…1385)

fix: check filemtime in admin site images panel (lk-arpg#1398)

3443af4

fix(characters): clarify character edit button labels (lk-arpg#1404)

6a42ac5

* fix(character): Minor button renaming * Change 'Edit Notes' to 'Edit Description' * Change 'Edit Features' to 'Edit Traits' link text

Merge remote-tracking branch 'ext-ScuffedNewt/extension/sellable-char…

04d8026

…as' into extension-pr/sellable-charas

fix: hardcoded ID values for adoption center and users, validation er…

70d427a

…rors

refactor: fix blade formatting

609fee1

refactor: fix PHP styling

dd43a59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update sellable charas to v3 and fix hardcoded values#274

Update sellable charas to v3 and fix hardcoded values#274
perappu wants to merge 1541 commits intoScuffedNewt:extension/sellable-charasfrom
perappu:extension-pr/sellable-charas

perappu commented Jan 23, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Conversation

perappu commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

perappu commented Jan 23, 2026 •

edited

Loading