ffmpeg: added a method for accessing the raw data of a frame#519
ffmpeg: added a method for accessing the raw data of a frame#519timleg002 wants to merge 3 commits intoScuffleCloud:mainfrom
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 78.96% 78.95% -0.02%
==========================================
Files 327 327
Lines 24383 24343 -40
==========================================
- Hits 19255 19220 -35
+ Misses 5128 5123 -5
... and 3 files with indirect coverage changes
🚀 New features to boost your workflow:
|
|
Hi, thanks for the contributions! Regarding the Release Checks issue: you’ll need to add a changelog entry to your PR, describing the changes you made. There’s an example file in the |
|
In addition to @SimaoMoreira5228 's comments, it may be nice to have a simple test or two to ensure that the output is correct. Since it's returning raw data, using snap would likely prove to be useful here. We have many tests that use snap so feel free to pick any of them as an example to go off of. Thank you for the contribution! |
| } | ||
|
|
||
| /// Returns the entire data buffer | ||
| pub fn get_all(&self) -> &[u8] { |
There was a problem hiding this comment.
I am not a huge fan of the name of this function. I think we should also add a comment about alignment / padding values. Perhaps get_buffer
Since these lines also include the padding values / alignment and is not just the raw frame data.
6 participants
This new method allows accessing the entire data buffer of a
FrameData. Useful for rendering raw pixel data to the screen.