Skip to content

docs(system-overview): scope symlink-escape claim to upload; clone gap tracked in #182#197

Merged
parthrohit22 merged 1 commit into
Second-Origin:devfrom
parthrohit22:chore/docs-cleanup
Jul 26, 2026
Merged

docs(system-overview): scope symlink-escape claim to upload; clone gap tracked in #182#197
parthrohit22 merged 1 commit into
Second-Origin:devfrom
parthrohit22:chore/docs-cleanup

Conversation

@parthrohit22

Copy link
Copy Markdown
Collaborator

Summary

SYSTEM_OVERVIEW.md incorrectly stated that symlink-escape rejection applies to the GitHub clone path. Only upload extraction guards symlinks (storage/local.py:121); the clone tree walk follows symlinks (verified, issue #182 — filesystem disclosure + recursion/DoS). This corrects the documentation to match the code and avoids overstating a security control.

Linked issue

Related to #182

What changed

Acceptance criteria completed

Testing performed

Documentation-only change; no code/test impact. Verified the three edited passages read consistently with storage/local.py:121 (upload guard) and repository_parser.py (clone walk follows symlinks).

Screenshots

Not applicable

Security and data considerations

Documentation honesty fix: removes a false claim that the clone path rejects symlink escapes. No code, secrets, or data changed.

Dependencies and blocked work

Depends on #182 for the actual clone-path hardening (this PR only documents the current state).

Scope changes or remaining work

None — documentation only.

Contributor checklist

…p tracked in Second-Origin#182

SYSTEM_OVERVIEW.md incorrectly stated symlink-escape rejection applied to the GitHub clone path. Only upload extraction guards symlinks (storage/local.py:121); the clone tree walk follows symlinks (issue Second-Origin#182, filesystem disclosure + recursion). Corrected the import diagram, validation node, and the untrusted-input note to scope the guard to upload and reference Second-Origin#182.
@parthrohit22
parthrohit22 merged commit fd4fb1e into Second-Origin:dev Jul 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant