Conversation
Unfortunately, the convenience of e.g. `.complement()` working for both slices and owned iterators was outweighed by `ToNucleotideLike` infecting surrounding generics. This change eliminates `ToNucleotideLike` and makes it possible to use `NucleotideIter` when iterating over `&[impl NucleotideLike]`.
Contributor
Author
|
If this is too large to review, let me know and I may be able to split it into some smaller PRs. (no promises until I try it though) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of
NucleotideIterworks with iterators ofNucleotide,&Nucleotide,NucleotideAmbiguous,&NucleotideAmbiguousandimpl NucleotideLike, but not&impl NucleotideLike. For example the following code currently doesn't compile:This PR removes the kludgey infectious
ToNucleotideLiketrait I came up with and instead of relies on how type resolution of methods is a bit smarter than traits.