docs: add ntlm_time/ntlm_requests directives and nginx ≥1.25 compatibility note#5
Merged
matthias-lay merged 1 commit intomasterfrom May 6, 2026
Merged
Conversation
…ibility notes Agent-Logs-Url: https://github.com/Securepoint/nginx-ntlm-module/sessions/288a378e-ba99-4203-8a44-9de59e5e9747 Co-authored-by: matthias-lay <163420385+matthias-lay@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
matthias-lay
May 6, 2026 10:11
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README was missing the two directives introduced in PR #4 and had no guidance on nginx version compatibility for the segfault regression.
New directives
ntlm_time 1h— max wall-clock age of a cached upstream connection; connection is retired after this duration regardless of idle statentlm_requests 1000— max requests per cached connection before it is closed and replacednginx version compatibility
Added a compatibility table. Key note: nginx ≥ 1.25 (including 1.28.3) changed
ngx_http_upstream_handlerto expectc->datato be the request pointer. Earlier module releases stored the NTLM cache item there on idle connections, causing segfaults. Fixed in PR #4 — builds frommainare required for nginx ≥ 1.25.