lints: complete the canonical lints block - #2
Merged
Merged
Conversation
lzo carried a partial block: unsafe_code = "forbid" and pedantic, but no
unwrap_used/expect_used, no correctness/suspicious, and none of the
canonical cast_* allows. The panic lints are the gap that matters - this
crate decodes attacker-controllable compressed streams, so ADR-0012's
untrusted-input superset applies.
Added: all, correctness = "deny", suspicious = "deny", unwrap_used =
"deny", expect_used = "deny", and the canonical cast_*/module_name/
must_use/missing_panics allows.
The two pre-existing allows (verbose_bit_mask, missing_errors_doc) are
kept with their original rationale comments, but rewritten from bare
`= "allow"` to `{ level = "allow", priority = 1 }`. That is required, not
cosmetic: clippy's lint_groups_priority rejects a manifest where a lint
group set to "deny" shares priority 0 with an individual lint, so the
bare form fails the build once correctness/suspicious are denied.
Zero findings in production code. The unwraps that surfaced are all in
tests/, which now carry the sanctioned top-level allow.
Gate: cargo build --all-targets, cargo test, cargo clippy --all-targets
-- -D warnings, cargo fmt --check - all clean.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lints: complete the canonical lints block
lzo carried a partial block: unsafe_code = "forbid" and pedantic, but no
unwrap_used/expect_used, no correctness/suspicious, and none of the
canonical cast_* allows. The panic lints are the gap that matters - this
crate decodes attacker-controllable compressed streams, so ADR-0012's
untrusted-input superset applies.
Added: all, correctness = "deny", suspicious = "deny", unwrap_used =
"deny", expect_used = "deny", and the canonical cast_*/module_name/
must_use/missing_panics allows.
The two pre-existing allows (verbose_bit_mask, missing_errors_doc) are
kept with their original rationale comments, but rewritten from bare
= "allow"to{ level = "allow", priority = 1 }. That is required, notcosmetic: clippy's lint_groups_priority rejects a manifest where a lint
group set to "deny" shares priority 0 with an individual lint, so the
bare form fails the build once correctness/suspicious are denied.
Zero findings in production code. The unwraps that surfaced are all in
tests/, which now carry the sanctioned top-level allow.
Gate: cargo build --all-targets, cargo test, cargo clippy --all-targets
-- -D warnings, cargo fmt --check - all clean.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
🤖 Generated with Claude Code