fix: allow port number to be maintained to permit use of developmentstorage#91
Draft
mikecowie-seequent wants to merge 1 commit intoSeequentEvo:mainfrom
Draft
Conversation
| name = "evo-sdk-common" | ||
| description = "Python package that establishes a common framework for use by client libraries that interact with Seequent Evo APIs" | ||
| version = "0.4.2" | ||
| version = "0.4.2.a0" |
Contributor
Author
There was a problem hiding this comment.
To be updated (likely force-push) when confirmed working from the other side of this.
mikecowie-seequent
force-pushed
the
allow-nonstandard-ports
branch
from
07bb5f6 to
2482cb7
Compare
mikecowie-seequent
force-pushed
the
allow-nonstandard-ports
branch
from
2482cb7 to
509d81c
Compare
stephanwindischmann
approved these changes
Aug 12, 2025
stephanwindischmann
left a comment
stephanwindischmann
left a comment
There was a problem hiding this comment.
Change looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For internal development of evo services, we want to be able to run storage service quickly in test suite on a non-standard port.
Therefore the SDK should maintain the port in the URLs, if a port was provided as part of the base URL.
Have factored out the url parsing into its own util module to isolate the logic.
Checklist