Skip to content

correction possible bug maybe if fast-path detects an UTF-8 violation… #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Seldaek merged 2 commits into from
Jun 12, 2026
Merged

correction possible bug maybe if fast-path detects an UTF-8 violation… #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30dda49
correction possible bug maybe if fast-path detects an UTF-8 violation…
LLyaudet Jun 11, 2026
4a6fad7
Remove getFastPAth and arg complications
Seldaek Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/Seld/JsonLint/Utf8Validator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ public static function validate($input)
{
// Fast-path
// But before PHP 5.4 Unicode support has bugs.
if (PHP_VERSION_ID >= 50400) {
$useFastPath = PHP_VERSION_ID >= 50400;
if ($useFastPath) {
if (function_exists("mb_check_encoding")) {
if (mb_check_encoding($input, 'UTF-8')) {
return;
Expand Down Expand Up @@ -294,6 +295,30 @@ public static function validate($input)
true
);
}
// The fast-path flagged this input as invalid UTF-8, yet the manual RFC 3629
// scan above found no fault. The two must always agree, so reaching here means
// the fast-path caught something the scan missed - surface it rather than
// silently accepting the input as valid.
if ($useFastPath) {
throw new InvalidEncodingException(
"Fast-path detected an error that the manual scan could not find. "
."Please report it at https://github.com/Seldaek/jsonlint/issues.",
"0",
array(
'current_octet' => $currentOctet,
'continuation_octet_needed' => $continuationOctetNeeded,
'offset_in_octets_from_string_start' => $offsetInOctetsFromStringStart,
'offset_in_characters_from_string_start' => $offsetInCharactersFromStringStart,
'character_start_position_from_string_start' => $characterStartPositionFromStringStart,
'line' => $currentLineNumber,
'offset_in_octets_from_line_start' => $offsetInOctetsFromLineStart,
'offset_in_characters_from_line_start' => $offsetInCharactersFromLineStart,
'character_start_position_from_line_start' => $characterStartPositionFromLineStart,
'current_continuation_octet_minimum' => $currentContinuationOctetMinimum,
'current_continuation_octet_maximum' => $currentContinuationOctetMaximum,
)
);
}
}

/**
Expand Down