Skip to content

test: Improve input pipeline diagnostic bisect tests#50

Merged
mark-e-deyoung merged 2 commits intomainfrom
input-trace-improvements-16151092667313884564
May 1, 2026
Merged

test: Improve input pipeline diagnostic bisect tests#50
mark-e-deyoung merged 2 commits intomainfrom
input-trace-improvements-16151092667313884564

Conversation

@mark-e-deyoung
Copy link
Copy Markdown
Collaborator

This PR addresses gaps and shortfalls in the input pipeline testing by implementing expanded trace test capabilities. Specifically, it implements the injection of events into the noVNC canvas using Playwright to confirm the client-side trace, and expands the VNC probe to perform drag-and-drop, scrolling, and modifier chord events, ensuring translation correctness from VNC -> X11 -> Wine. Additionally, the remaining gaps identified (latency thresholds, scaled viewport testing) have been formally captured in the issue backlog (issues.json).


PR created automatically by Jules for task 16151092667313884564 started by @mark-e-deyoung

- Track latency gating and viewport scaling/UI occlusion input testing as new tracked issues in `issues.json`.
- Replace the mocked API client trace injection with a real Playwright interaction to validate frontend event routing in `diagnose-input-trace.sh`.
- Expand VNC testing to include drag gestures, vertical scrolling, and modifier key combinations in the VNC probe in `diagnose-input-trace.sh`.

Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Update the base image in `tests/e2e/Dockerfile` from `mcr.microsoft.com/playwright/python:v1.58.0-noble` to `mcr.microsoft.com/playwright/python:v1.59.0-noble` to match the expected version required by the installed Playwright package. This resolves the CI test failure during browser launch.

Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
@mark-e-deyoung mark-e-deyoung merged commit 0a5c969 into main May 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant