Remove assumption user ID is 1000#553
Draft
ukkopahis wants to merge 2 commits intoSensorsIot:masterfrom
Draft
Conversation
2fc86ca to
0b29eb3
Compare
|
Err - 100 ? Should that be 1000 ? I think it's only the commit message above. I couldn't find any 100 in the changed files (but I do have ancient eyeballs). |
Author
I was trying to show what it does on a non-default install. Clarified. |
0b29eb3 to
157cebe
Compare
993e156 to
3fa64f7
Compare
8bdfdb8 to
c60b752
Compare
ukkopahis
added a commit
to ukkopahis/IOTstack
that referenced
this pull request
May 4, 2022
This container includes cron and should be easier to use than the current duck.sh script. After a test period this should completely replace the current ./duck/duck.sh script. Currently uses my fork of linuxserver/docker-duckdns to include some needed pull-requests that are pending. Depends on SensorsIot#553 to generate .env with IOTSTACK_UID and IOTSTACK_GID Mkdocs and material versions updated to fix layout bug.
Merged
9074543 to
27fb6c0
Compare
ukkopahis
added a commit
to ukkopahis/IOTstack
that referenced
this pull request
May 18, 2022
This container includes cron and should be easier to use than the current duck.sh script. After a test period this should completely replace the current ./duck/duck.sh script. Currently uses my fork of linuxserver/docker-duckdns to include some needed pull-requests that are pending upstream pull-requests. Depends on SensorsIot#553 to generate .env with IOTSTACK_UID and IOTSTACK_GID Mkdocs and material versions updated to fix layout bug.
ukkopahis
added a commit
to ukkopahis/IOTstack
that referenced
this pull request
May 18, 2022
This container includes cron and should be easier to use than the current duck.sh script. After a test period this should completely replace the current ./duck/duck.sh script. Currently uses my fork of linuxserver/docker-duckdns to include some needed pull-requests that are pending upstream pull-requests. Depends on SensorsIot#553 to generate .env with IOTSTACK_UID and IOTSTACK_GID Mkdocs and material versions updated to fix layout bug.
Author
Alternate suggestion (NOT RECOMMENDED)I think it's better to change this so a Templates would still use the syntax allowing .env-use: - PUID=${IOTSTACK_UID:?replace with your actual UID}buildstack_menu.py would identify template environment variable values matching - PUID=1000Resoning
Drawbacks
|
On menu.sh start, store current UID and GID to .env, if they are missing. Use these to run services that use a customized user.
27fb6c0 to
0c6d564
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET
On menu.sh start, store current UID and GID to
.env, if they are missing.Use these to run services that support a custom user setting.
Lines added to
.envby menu.sh are e.g.:And in templates and services:
When dropping the ID=1000 assumption, there is only one chance to get this right:
Other small changes:
Resolves #542, Fixes #183