Skip to content

fix(nodered): fix FileNotFoundError and PermissionError in preBuild #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcosJRcwb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(nodered): fix FileNotFoundError and PermissionError in preBuild #823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .templates/nodered/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,10 @@ def preBuild():
with open(r'%s/Dockerfile.template' % serviceTemplate, 'r') as dockerTemplate:
templateData = dockerTemplate.read()

with open(r'%s' % addonsFile) as objAddonsFile:
addonsSelected = yaml.load(objAddonsFile)

addonsInstallCommands = ""
if os.path.exists(addonsFile):
with open(r'%s' % addonsFile) as objAddonsFile:
addonsSelected = yaml.load(objAddonsFile)
installCommand = addonsSelected["dockerFileInstallCommand"]
for (index, addonName) in enumerate(addonsSelected["addons"]):
if (addonName == 'node-red-node-sqlite'): # SQLite requires a special param
Expand All @@ -125,8 +124,15 @@ def preBuild():

templateData = templateData.replace(dockerfileTemplateReplace, addonsInstallCommands)

with open(r'%s/Dockerfile' % serviceService, 'w') as dockerTemplate:
dockerTemplate.write(templateData)
dockerfilePath = r'%s/Dockerfile' % serviceService
try:
with open(dockerfilePath, 'w') as dockerTemplate:
dockerTemplate.write(templateData)
except PermissionError:
print("Error: Permission denied writing '{path}'.".format(path=dockerfilePath))
print("This can happen if a previous build was run as root.")
print("Fix with: sudo chown $USER:$USER {path}".format(path=dockerfilePath))
return False
print("Finished NodeRed Build script")
time.sleep(0.3)
return True
Expand Down