fix(install): drop stale cw_beacon.py copy (retired in c8ca09a)#12
Closed
sthomas69 wants to merge 1 commit into
Closed
fix(install): drop stale cw_beacon.py copy (retired in c8ca09a)#12sthomas69 wants to merge 1 commit into
sthomas69 wants to merge 1 commit into
Conversation
install.sh still copied pi/cw_beacon.py, but that file was removed when the legacy CW beacon API was retired (c8ca09a). Under `set -e` the missing-file cp aborts the script mid-run, so both a fresh install and `install.sh --update` die before the portal service is restarted. Remove the dead copy line. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Raspberry Pi install script to stop installing the cw_beacon.py utility.
Changes:
- Removed the
cw_beacon.pycopy/install step frompi/install.sh.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
90
to
95
| cp "$SCRIPT_DIR/plain_rfc2217_server.py" /usr/local/bin/plain_rfc2217_server.py | ||
| cp "$SCRIPT_DIR/wifi_controller.py" /usr/local/bin/wifi_controller.py | ||
| cp "$SCRIPT_DIR/ble_controller.py" /usr/local/bin/ble_controller.py | ||
| cp "$SCRIPT_DIR/cw_beacon.py" /usr/local/bin/cw_beacon.py | ||
| cp "$SCRIPT_DIR/bcm_gpio.py" /usr/local/bin/bcm_gpio.py | ||
| cp "$SCRIPT_DIR/gpclk.py" /usr/local/bin/gpclk.py | ||
| cp "$SCRIPT_DIR/morse.py" /usr/local/bin/morse.py |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pi/install.shstill copiespi/cw_beacon.py, but that file was removed when the legacy CW beacon API was retired (c8ca09a). Underset -e, the missing-filecpaborts the script mid-run — both a freshinstall.shandinstall.sh --updatedie before the portal service is restarted (line 89 copies portal.py, then it aborts at the cw_beacon line before the systemctl restart).Fix
Remove the dead
cp cw_beacon.pyline.bash -nclean.Verification
Ran
sudo bash pi/install.sh --updateon a Pi after this change: it completes cleanly, the portal service comes backactive, and/api/devicesserves all slots.